Kevin Hilman wrote: > Sudhakar Rajashekhara <sudhakar....@ti.com> writes: > >> This patch set corrects some issues with the existing EDMA >> driver and also adds support for EDMA resource (channel/slots) >> sharing between two processors (say ARM and DSP). >> >> The patch set has been tested on DM646x, OMAP-L137 and OMAP-L138 >> EVM boards. > > Hi Sudhakar, > > This series looks good. One minor request. > > For the last three patches, I think it would be helpful to describe in > the changelog or even better at the definition of the reserved arrays > what the channels are being reserved for. > > Kevin >
Hi Kevin Why is this comment from you (april 2009) no longer valid? >> I'm not crazy about this hard-coded reservation. >> >> The DSP code has a kernel-side driver (dsplinkk.) That driver >> should be doing the channel reservations. >> >> Kevin >> Sudhakar Rajashekhara (9): >> davinci: Correct return value of edma_alloc_channel api >> davinci: Keep count of channel controllers on a platform >> davinci: Fix edma_alloc_channel api for EDMA_CHANNEL_ANY case >> davinci: build list of unused EDMA events dynamically >> davinci: support for EDMA resource sharing >> davinci: da8xx/omap-l1xx: Add EDMA platform data for da850/omap-l138 >> davinci: da830/omapl137: Specify reserved channels/slots >> davinci: da850/omapl138: Specify reserved channels/slots >> davinci: dm646x: Specify reserved EDMA channel/slots for DM646x >> >> arch/arm/mach-davinci/devices-da8xx.c | 181 >> ++++++++++++++++++++++++++-- >> arch/arm/mach-davinci/dm355.c | 8 -- >> arch/arm/mach-davinci/dm644x.c | 10 -- >> arch/arm/mach-davinci/dm646x.c | 28 ++++- >> arch/arm/mach-davinci/dma.c | 101 ++++++++++++++--- >> arch/arm/mach-davinci/include/mach/edma.h | 4 +- >> 6 files changed, 276 insertions(+), 56 deletions(-) _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
