Sergei,

[...]
> > > +#if defined(CONFIG_ARCH_DAVINCI_DMx)
> > > +#define UART_PHYS        DAVINCI_UART0_BASE
> > > +#define UART_VIRT        IO_ADDRESS(UART_PHYS)
> > > +#endif
> >
> >    These UART addressed are machine-, not arch-specific.
> 
> Thanks.  Will change in v2.

On second thoughts, if we were to make these definitions machine specific, it 
would explode into excruciating verbosity:

#if     defined(CONFIG_MACH_DAVINCI_EVM)        || \
        defined(CONFIG_MACH_SFFSDR)             || \
        defined(CONFIG_MACH_NEUROS_OSD2)        || \
        defined(CONFIG_MACH_DAVINCI_DM355_EVM)  || \
        defined(CONFIG_MACH_DM355_LEOPARD)      || \
        defined(CONFIG_MACH_DAVINCI_DM6467_EVM) || \
        defined(CONFIG_MACH_DAVINCI_DM6467TEVM) || \
        defined(CONFIG_MACH_DAVINCI_DM365_EVM)

Is that the preferred approach?  Would we be better off leaving UART selection 
arch-specific for now and making it machine-specific as and when a new board 
deviates from the norm on that arch?

Regards
Cyril.
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to