Sergei Shtylyov <sshtyl...@mvista.com> writes:

> Hello.
>
> Kevin Hilman wrote:
>
>>>> DA8xx OHCI driver fails to load due to failing clk_get() call for the USB 
>>>> 2.0
>>>> clock. Arrange matching USB 2.0 clock by the clock name instead of the 
>>>> device.
>>>> (Adding another CLK() entry for "ohci.0" device won't do -- in the future 
>>>> I'll
>>>> also have to enable USB 2.0 clock to configure CPPI 4.1 module, in which 
>>>> case
>>>> I won't have any device at all.)
>>>>         
>>>   This was actually a part of CPPI 4.1 platform init. patch, but I've
>>> just realized it's necessary for OHCI too. Didn't notice it
>>> before. :-/
>>>
>>>     
>>>> Signed-off-by: Sergei Shtylyov <sshtyl...@ru.mvista.com>
>>>>
>>>> ---
>>>> The patch is against the recent DaVinci tree.
>>>>         
>>>   Kevin, could we squeeze it into 2.6.34?
>>>
>>>     
>>
>> Sure, if you convice me that this doesn't break the clk_get() in the
>> musb driver.
>>   
>
>   Sure, it doesn't. MUSB driver calls clk_get(dev, plat->clock). We're
> passing "usb20" as plat->clock, see da8xx_register_usb20() in usb.c...

/me convinced.  Thanks.

Will submit for 2.6.34-rc, but may be too late.  If I miss, will queue
for 2.6.35 in davinci-next.

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to