Hi Ben, On Tue, Aug 02, 2011 at 18:32:39, Ben Gardiner wrote: > Hi Sudhakar, > > On Thu, Jul 21, 2011 at 5:39 AM, Rajashekhara, Sudhakar > <sudhakar....@ti.com> wrote: > > This patch adds cpufreq support for NAND driver. During cpufreq > > transition, 'davinci_aemif_setup_timing()' function will be called > > to reconfigure that AEMIF timings for the new frequency. > > I can see that this will work fine for dacinci_nand -- and it is a > welcomed feature also -- thank you for the effort to push this > upstream. > > Seeing this support added directly to davinci_nand driver made me > think -- now this driver has another reference to platform-specific > functions in arch/arm/mach-davinci/aemif.c. Recently the c6x project > pushed a fix to remove references to a platform specific include. Not > that you are re-introducing this include but in a more general sense: > perhaps the features/functions of the AEMIF _bus_ should be removed > from the davinci_nand driver?
Good point! arch/arm/mach-davinci/aemif.c should be moved to drivers/ Because AEMIF is present on C6x and OMAP architectures as well and not limited to DaVinci. I am not sure if there are any existing "memory interface" drivers. Moving to drivers/misc/ may be a good point to start. Making AEMIF a new bus type is an interesting idea as well. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source