On Tue, Jan 31, 2012 at 12:27:11PM +0100, Heiko Schocher wrote: > Hello Grant, > > Grant Likely wrote: > > On Mon, Jan 23, 2012 at 09:56:04AM +0100, Heiko Schocher wrote: > >> add of support for the davinci_emac driver. > >> > >> Signed-off-by: Heiko Schocher <h...@denx.de> > >> Cc: davinci-linux-open-source@linux.davincidsp.com > >> Cc: linux-arm-ker...@lists.infradead.org > >> Cc: devicetree-disc...@lists.ozlabs.org > >> Cc: net...@vger.kernel.org > >> Cc: Grant Likely <grant.lik...@secretlab.ca> > >> Cc: Sekhar Nori <nsek...@ti.com> > >> Cc: Wolfgang Denk <w...@denx.de> > >> --- > >> .../bindings/arm/davinci/davinci_emac.txt | 46 ++++++++ > >> drivers/net/ethernet/ti/davinci_emac.c | 111 > >> +++++++++++++++++++- > >> 2 files changed, 156 insertions(+), 1 deletions(-) > >> create mode 100644 > >> Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> > >> diff --git > >> a/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> b/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> new file mode 100644 > >> index 0000000..4e5dc8d > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/arm/davinci/davinci_emac.txt > >> @@ -0,0 +1,46 @@ > >> +* Texas Instruments Davinci EMAC > >> + > >> +This file provides information, what the davice node > >> +for the davinci_emac interface contain. > >> + > >> +Required properties: > >> +- compatible: "ti,davinci-emac"; > >> +- reg: Offset and length of the register set for the device > >> +- ctrl_reg_offset: offset to control register > >> +- ctrl_mod_reg_offset: offset to control module register > >> +- ctrl_ram_offset: offset to control module ram > > > > Should these be explicit properties, or can they be discerned from the > > compatible string (which should include the hardware version; see > > below). > > Hmm.. I do not know all davinci SoCs ... maybe someone from TI > could answer this? But I think, we could discern this from > the compatible string. I prepare this for v2. Maybe it is Ok, > if I do this only for my hardwareversion and others add this, > if needed? (maybe the better approach, as I can code it, but > have no hw for testing it ... so it maybe is buggy) > > > Also, any custom properties that are specific to a binding really > > should include a vendor prefix ('ti,') to avoid namespace collisions > > with common bindings. > > Yep, is "ti,davinci-" ok? Also I should use dashes instead > underscores, right?
Correct. > > >> +- hw_ram_addr: hardware ram addr > > > > Can this be added as a second tuple in the reg property? > > No, if I know this right, this is used for DMA, and also could be RAM. Not getting what you mean here. The second tuple could be omitted if there isn't a physical address for hardware ram. _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source