Em Thu, 16 Aug 2012 19:32:00 +0530 Prabhakar Lad <[email protected]> escreveu:
It is amazing how many SOB's/acks are in this patch and nobody asked you to provide a patch description... the subject just tells what the code is also telling. Could you please provide a better patch description? Thanks! Mauro > From: Lad, Prabhakar <[email protected]> > > Signed-off-by: Lad, Prabhakar <[email protected]> > Signed-off-by: Manjunath Hadli <[email protected]> > Cc: Hans Verkuil <[email protected]> > --- > drivers/media/video/davinci/vpif_capture.c | 12 +++++++----- > drivers/media/video/davinci/vpif_display.c | 14 ++++++++------ > 2 files changed, 15 insertions(+), 11 deletions(-) > > diff --git a/drivers/media/video/davinci/vpif_capture.c > b/drivers/media/video/davinci/vpif_capture.c > index 266025e..a87b7a5 100644 > --- a/drivers/media/video/davinci/vpif_capture.c > +++ b/drivers/media/video/davinci/vpif_capture.c > @@ -311,12 +311,14 @@ static int vpif_start_streaming(struct vb2_queue *vq, > unsigned int count) > } > > /* configure 1 or 2 channel mode */ > - ret = vpif_config_data->setup_input_channel_mode > - (vpif->std_info.ycmux_mode); > + if (vpif_config_data->setup_input_channel_mode) { > + ret = vpif_config_data->setup_input_channel_mode > + (vpif->std_info.ycmux_mode); > > - if (ret < 0) { > - vpif_dbg(1, debug, "can't set vpif channel mode\n"); > - return ret; > + if (ret < 0) { > + vpif_dbg(1, debug, "can't set vpif channel mode\n"); > + return ret; > + } > } > > /* Call vpif_set_params function to set the parameters and addresses */ > diff --git a/drivers/media/video/davinci/vpif_display.c > b/drivers/media/video/davinci/vpif_display.c > index e129c98..1e35f92 100644 > --- a/drivers/media/video/davinci/vpif_display.c > +++ b/drivers/media/video/davinci/vpif_display.c > @@ -280,12 +280,14 @@ static int vpif_start_streaming(struct vb2_queue *vq, > unsigned int count) > } > > /* clock settings */ > - ret = > - vpif_config_data->set_clock(ch->vpifparams.std_info.ycmux_mode, > - ch->vpifparams.std_info.hd_sd); > - if (ret < 0) { > - vpif_err("can't set clock\n"); > - return ret; > + if (vpif_config_data->set_clock) { > + ret = > + vpif_config_data->set_clock(ch->vpifparams.std_info.ycmux_mode, > + ch->vpifparams.std_info.hd_sd); > + if (ret < 0) { > + vpif_err("can't set clock\n"); > + return ret; > + } > } > > /* set the parameters and addresses */ Cheers, Mauro _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
