On Tuesday 20 May 2014 12:49 PM, Prabhakar Lad wrote:
> Hi,
>
> On Tue, May 20, 2014 at 12:08 AM, Kevin Hilman <khil...@linaro.org> wrote:
>> As found by my automated boot tester[1], dm365 EVM and da850 EVM started
>> failing boot tests in today's linux-next.
>>
>> I haven't had the time to bisect, but it appears to be related to some
>> devres failures in the EMAC driver. Full boot log below for the
>> da850evm (the dm365 fault looks the same.)
>>
> I too hit this issue, this was introduced with commit id:
> e194312854edc22a2faf1931b3c0608fe20cb969 (drivers: net:
> davinci_cpdma: Convert kzalloc() to devm_kzalloc().)
> Reverting this patch fixes it.
> From the outset patch looks good, not sure why exactly it is failing.
Following patch seems to help. I will post it for review after some more
analysis.
Thanks,
Sekhar
diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/da
index e76eae5..9cd0d9c 100644
--- a/drivers/net/ethernet/ti/davinci_emac.c
+++ b/drivers/net/ethernet/ti/davinci_emac.c
@@ -1930,7 +1930,7 @@ static int davinci_emac_probe(struct platform_device *pdev
hw_ram_addr = (u32 __force)res->start + pdata->ctrl_ram_offset;
memset(&dma_params, 0, sizeof(dma_params));
- dma_params.dev = emac_dev;
+ dma_params.dev = &pdev->dev;
dma_params.dmaregs = priv->emac_base;
dma_params.rxthresh = priv->emac_base + 0x120;
dma_params.rxfree = priv->emac_base + 0x140;
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
