To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=59673
User fs changed the following:
What |Old value |New value
================================================================================
Status|NEW |RESOLVED
--------------------------------------------------------------------------------
Issue type|DEFECT |TASK
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------
------- Additional comments from [EMAIL PROTECTED] Wed Jan 4 03:37:45 -0800
2006 -------
> basically, you want to alter the source code for the sake of pecular build
> environments.
Ehm, yes, in some sense. But given that our build environments are complex
enough (this does hold for both the SO and the OOo build env), I don't consider
this *per se* a Bad Thing.
> The source code will be more complex and perharps slower, just for building
> considerations. I feel this is "Not Good (TM)".
I don't believe in it being slower, except perhaps for the very first connection
attempt where the library has to be loaded. All subsequent calls should suffer a
very minmal penalty only, since instead of
pConn = new KabConnection( this );
the code would be
pConn = static_cast< KabConnection* >( (m_pConnectionFactoryFunc*)( this ) );
, i.e. one additional re-direction through a function pointer.
More complex ... yes, slightly. But IMO still a cleaner architecture to separate
the UNO component (the mere driver) from the system-dependent implementation.
Since you did not have "strong opposition" :) against this, I implemented it in
CWS kabrefine. Changes are in connectivity/source/drivers/kab and scp2/source.
For the potential conflicts with CWS configure13: I will resync kabrefine once
configure13 is integrated, this will unveil the conflicts.
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
