To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=62664
------- Additional comments from [EMAIL PROTECTED] Tue Aug 22 06:43:34 -0700 2006 ------- - please remove the unused #include <stdio.h> and the fprintf - the loop in convertUnicodeStringToLength is unnecessary, and expensive. Simply convert the OUString to an OString, and check the length afterwards. - don't use sprintf (which is prone to buffer overflows and the like), but O[U]String::valueOf - there's a typo in the exception message: It must be "length", not "lenght" - another typo: "exceeds" instead of "exceed" - please remove adjustCharSets completely, instead of just commenting out. No need to keep the dead code. - instead of changing m_nTextEncoding in file::OConnection::construct (which is also used for the flat driver), please overwrite the "construct" method in ODbaseConnection, to minimize possible side effects here --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
