To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=100349





------- Additional comments from f...@openoffice.org Thu Mar 19 13:17:12 +0000 
2009 -------
fs->aw: Before your change in aw063, the code in
FmTextControlShell::executeAttributeDialog looked like this:
  {
    ::std::auto_ptr< SfxItemPool > pPool( EditEngine::CreatePool() );
    pPool->FreezeIdRanges();
    SfxItemSet aPureItems( *pPool );
    ...
  }
After your change, it looked like this:
  {
    SfxItemPool* pPool = EditEngine::CreatePool();
    pPool->FreezeIdRanges();
    SfxItemSet aPureItems( *pPool );
    ...
    SfxItemPool::Free(pPool);
  }

In particular, this implies that now the pool is freed before aPureItems is
destroyed. Unfortunately, the SfxItemSet destructor accesses its pool - and this
is what crashes here.

Next time you change something in foreign code, please at least once actually
*run* your changes. In this particular case, this would have crashed immediately
- and thus saved me much more time than it would have cost you. Thanks.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@dba.openoffice.org
For additional commands, e-mail: issues-h...@dba.openoffice.org

Reply via email to