Hey Greg, this looks really cool!
I have a couple of quick notes, though:
* It looks like you include the docs for async queries and savepoints
about three times.
* In at least one place in teh docs, you just call the constant
"ASYNC" rather than "DBDPG_ASYNC".
* Shouldn't we have the async constants start with "PG_" like all the
other constants, rather than "DBDPG_"? I realize that they're
different than the sorts of constants directly supported by
PostgreSQL,
but surely we can control for that and keep things consistent.
* Do we need "OLDQUERY" in the cancel and wait constants? Seems kind
of unnecessary to me.
I really like the API. Thanks for doing this!
Best,
David
On Jul 12, 2007, at 07:30, [EMAIL PROTECTED] wrote:
Author: turnstep
Date: Thu Jul 12 07:30:57 2007
New Revision: 9728
Added:
DBD-Pg/trunk/t/08async.t
Modified:
DBD-Pg/trunk/Pg.h
DBD-Pg/trunk/Pg.pm
DBD-Pg/trunk/Pg.xs
DBD-Pg/trunk/dbdimp.c
DBD-Pg/trunk/dbdimp.h
Log:
First pass at async support: still a little rough, but a good start.
Modified: DBD-Pg/trunk/Pg.h
======================================================================
========
--- DBD-Pg/trunk/Pg.h (original)
+++ DBD-Pg/trunk/Pg.h Thu Jul 12 07:30:57 2007
@@ -17,6 +17,9 @@
#define DBDPG_TRUE (bool)1
#define DBDPG_FALSE (bool)0
+#define DBDPG_ASYNC 1
+#define DBDPG_OLDQUERY_CANCEL 2
+#define DBDPG_OLDQUERY_WAIT 4
