[EMAIL PROTECTED] wrote:
> 
> With these changes plus my previous patch, all but 1 test in basic.t works for
> me.  The patch fixes a bug in neat() whereby neat("2") was returning "''". 

Thanks again, I really appreciate it.

> I've
> also ported a usage of foreach() to Perl 5.004 syntax and added quotes around
> hash keys to eliminate warnings under that tried and true Perl release.

Yep, as a matter of fact, I did that myself too last night after sending
off the message to this list.  It works fine on 5.004 with DBD::XBase,
DBD::CSV, SQL::Statement, all of which also work under 5.004.  I did
have to patch two foreach()s in DBI.pm too and I don't know if Tim wants
to be held to having DBI.pm pass 5.004.
 
> The test that fails is number 7, "$switch->{'Attribution'} =~ m/DBI.*? by Tim

I'll look into that, thanks for spotting it.

-- 
Jeff

Reply via email to