Tim,

I don't know if these items have been corrected in 1.35, since I cannot 
find it on any of the CPAN mirrors.  Unless this is applied, proxy will 
not even pass regression tests due to compile errors:

diff -ur DBI-1.34.orig/lib/DBD/Proxy.pm DBI-1.34/lib/DBD/Proxy.pm
--- DBI-1.34.orig/lib/DBD/Proxy.pm      2003-02-28 12:50:28.000000000 -0500
+++ DBI-1.34/lib/DBD/Proxy.pm   2003-03-07 20:23:49.000000000 -0500
@@ -61,7 +61,7 @@
 sub proxy_set_err {
   my ($h,$errmsg) = @_;
   my ($err,$state) = 
-    ($errmsg =~ s/ \[err=(.*?),state=(.*?)\]//) ? ($1,$2) : (1,5 x ' ');
+    ($errmsg =~ s/ \[err=(.*?),state=(.*?)\]//) ? ($1,$2) : (1,'');
 
   return DBI::set_err($h, $err, $errmsg, $state);
 }
@@ -269,7 +269,7 @@
     # to let people trade safety for speed if they need to.
     undef $dbh->{'proxy_dbh'};    # Bug in Perl 5.004; would prefer delete
     undef $dbh->{'proxy_client'};
-    $this->SUPER::STORE('Active' => 0);
+    $dbh->SUPER::STORE('Active' => 0);
     1;
 }
 
diff -ur DBI-1.34.orig/t/80proxy.t DBI-1.34/t/80proxy.t
--- DBI-1.34.orig/t/80proxy.t   2002-06-13 08:28:13.000000000 -0400
+++ DBI-1.34/t/80proxy.t        2003-03-08 09:18:12.000000000 -0500
@@ -103,7 +103,7 @@
 my $dsn = "DBI:Proxy:hostname=127.0.0.1;port=$port;debug=1;dsn=DBI:ExampleP:";
 
 print "Making a first connection and closing it immediately.\n";
-Test(eval { DBI->connect($dsn, '', '', { 'PrintError' => 0 }) })
+Test(eval { my $dbh = DBI->connect($dsn, '', '', { 'PrintError' => 0 }); 
$dbh->disconnect })
     or print "Connect error: " . $DBI::errstr . "\n";
 
 print "Making a second connection.\n";
@@ -392,6 +392,7 @@
             "\n");
 Test($csr_a->finish());
 
+$dbh->disconnect;
 
 # Test $dbh->func()
 #  print "Testing \$dbh->func().\n";

Reply via email to