(I hope you don't mind me jumping in on the dbi-devel list with this small
patch; I am not a subscriber so please cc me on replies.)

Sometimes DBI will give an uninitalized value warning when reporting some
other error.  This is harmless but a bit annoying and worrying.  This patch
fixes the warning:

--- DBI-1.37/DBI.pm     2003-05-15 18:48:56.000000000 +0100
+++ DBI-1.37-new/DBI.pm 2003-07-14 11:15:32.553096000 +0100
@@ -581,7 +581,10 @@
        my $dbh;
        unless ($dbh = $drh->$connect_meth($dsn, $user, $pass, $attr)) {
            $user = '' if !defined $user;
-           my $msg = "$class connect('$dsn','$user',...) failed: ".$drh->errstr;
+           $dsn = '' if !defined $dsn;
+           my $errstr = $drh->errstr;
+           $errstr = '(no error string)' if !defined $errstr;
+           my $msg = "$class connect('$dsn','$user',...) failed: $errstr";
            DBI->trace_msg("       $msg\n");
            unless ($attr->{HandleError} && $attr->{HandleError}->($msg, $drh, $dbh)) {
                Carp::croak($msg) if $attr->{RaiseError};


-- 
Ed Avis <[EMAIL PROTECTED]>

Reply via email to