Umm,
Useless use of private variable in void context at Makefile.PL line 204.
using "return $rv;" instead of just "$rv;" seems to keep it happy.
Tim.
On Tue, Aug 19, 2003 at 11:54:48AM +0100, Leon Brocard wrote:
> Here's a simple little patch to DBI Makefile.PL to make sure it gives
> off the correct return value. This is important if you incorporate the
> Makefile.PL into another system or use recursive Makefile.PL stuff.
>
> Patch originally by Arthur Bergman.
>
> Index: Makefile.PL
> ===================================================================
> RCS file: /usr/local/repository/Vendor/CPAN/DBI/Makefile.PL,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 Makefile.PL
> --- Makefile.PL 2003/08/19 10:34:16 1.1.1.1
> +++ Makefile.PL 2003/08/19 10:44:34
> @@ -179,7 +179,7 @@
>
>
> $Verbose = $::opt_v;
> -WriteMakefile(
> +my $rv = WriteMakefile(
> dbd_edit_mm_attribs(\%opts, {
> create_pp_tests => 1,
> })
> @@ -201,6 +201,7 @@
> use the ppm utility to fetch and install a prebuilt DBI instead.
> EOT
>
> +$rv;
>
> # =====================================================================
> --
> Leon Brocard.............................http://www.astray.com/
> scribot.................................http://www.scribot.com/
>
> ... This is a Tagline mirror ][ rorrim enilgaT a si sihT
