Tim Bunce wrote:
>
> On Mon, Oct 27, 2003 at 04:50:18PM +0100, Steffen Goeldner wrote:
> >
[...]
> >
> > Three cases cross my mind:
> >
> > 1) Return nothing (or an arbitrary value), i.e. the caller shouldn't
> > use that value.
> >
> > 2) Return a boolean value, indicating success or failure.
> >
> > 3) Return the new value.
> >
> > Tim, can you settle on one of these cases?
>
> I think it has to be 1 unless the driver docs indicate otherwise.
O.k., patch attached (which includes a few other small fixes).
Steffen
*** DBD.orig Wed Aug 20 02:15:42 2003
--- DBD.pm Tue Oct 28 22:21:43 2003
***************
*** 1230,1235 ****
--- 1230,1238 ----
implement driver-specific any code in your FETCH and STORE methods unless
you need extra logic/checks, beyond getting or setting the value.
+ Unless your driver documentation indicates otherwise, the return value of
+ the STORE method is unspecified and the caller shouldn't use that value.
+
=cut
#=head4 Other database handle methods
***************
*** 3086,3091 ****
--- 3089,3096 ----
=pod
+ =back
+
=over 2
=item Generating the type_info method
***************
*** 3117,3128 ****
lib/DBD/Driver/TypeInfo.pm.
You should review the output to ensure that it is sensible.
=head2 Writing DBD::Driver::db::get_info
! If you use the DBI::DBD::GetInfo module, then the code you need is
generated for you.
! If you decide not to use the DBI::DBD::GetInfo module, you should
probably borrow the code from a driver that has done so (eg
DBD::Informix from version 1.05 onwards) and crib the code from there,
or look at the code that generates that module and follow that.
--- 3122,3135 ----
lib/DBD/Driver/TypeInfo.pm.
You should review the output to ensure that it is sensible.
+ =back
+
=head2 Writing DBD::Driver::db::get_info
! If you use the DBI::DBD::Metadata module, then the code you need is
generated for you.
! If you decide not to use the DBI::DBD::Metadata module, you should
probably borrow the code from a driver that has done so (eg
DBD::Informix from version 1.05 onwards) and crib the code from there,
or look at the code that generates that module and follow that.
***************
*** 3137,3146 ****
=head2 Writing DBD::Driver::db::type_info_all
! If you use the DBI::DBD::TypeInfo module, then the code you need is
generated for you.
! If you decide not to use the DBI::DBD::TypeInfo module, you should
probably borrow the code from a driver that has done so (eg
DBD::Informix from version 1.05 onwards) and crib the code from there,
or look at the code that generates that module and follow that.
--- 3144,3153 ----
=head2 Writing DBD::Driver::db::type_info_all
! If you use the DBI::DBD::Metadata module, then the code you need is
generated for you.
! If you decide not to use the DBI::DBD::Metadata module, you should
probably borrow the code from a driver that has done so (eg
DBD::Informix from version 1.05 onwards) and crib the code from there,
or look at the code that generates that module and follow that.
***************
*** 3673,3679 ****
Jonathan Leffler <[EMAIL PROTECTED]> (previously <[EMAIL PROTECTED]>),
Jochen Wiedmann <[EMAIL PROTECTED]>,
! Steffen Goeldner <[EMAIL PROTECTED]>,
and Tim Bunce <[EMAIL PROTECTED]>.
=cut
--- 3680,3686 ----
Jonathan Leffler <[EMAIL PROTECTED]> (previously <[EMAIL PROTECTED]>),
Jochen Wiedmann <[EMAIL PROTECTED]>,
! Steffen Goeldner <[EMAIL PROTECTED]>,
and Tim Bunce <[EMAIL PROTECTED]>.
=cut
