On Mon, Jan 26, 2004 at 02:21:33PM -0000, Avis, Ed wrote:
> Tim Bunce <[EMAIL PROTECTED]> wrote:
> 
> >Actualy I did this instead, as it seems more correct:
> >
> >@@ -1720,5 +1721,6 @@
> >     sub execute_for_fetch {
> >        my ($sth, $fetch_tuple_sub, $tuple_status) = @_;
> >-       @$tuple_status = () if $tuple_status; # reset the status array
> >+       # start with empty status array
> >+       ($tuple_status) ? @$tuple_status = () : $tuple_status = undef;
> 
> But when I try that code it fails the tests I added.

Uh, groan. The diff I pasted was an old one where I was rechecking
that the tests failed by replacing [] with undef. This is the
right diff hunk:

@@ -1720,5 +1721,6 @@
     sub execute_for_fetch {
        my ($sth, $fetch_tuple_sub, $tuple_status) = @_;
-       @$tuple_status = () if $tuple_status; # reset the status array
+       # start with empty status array
+       ($tuple_status) ? @$tuple_status = () : $tuple_status = [];

        my ($err_count, %errstr_cache);


> Did you apply the patch to the test suite?

Yes, thanks. (I just had too many windows with diff in them :)

Tim.

Reply via email to