Attached is a patch that does for DBI what I've been doing in the Perl
core the past few weeks:
* Apply const qualifiers where possible
* Localize auto variables to internal blocks where possible
* Clean up complaints from high-stress GCC compiler warnings.
I've been building by using this set of changes to Makefile.PL, which
makes GCC pretty picky:
Index: Makefile.PL
===================================================================
--- Makefile.PL (.../DBI-1.48) (revision 17)
+++ Makefile.PL (.../trunk) (revision 17)
@@ -127,6 +127,7 @@
VERSION_FROM=> 'DBI.pm',
PREREQ_PM => { "Test::Simple" => 0.40 },
EXE_FILES => [ "dbiproxy$ext_pl", "dbiprof$ext_pl" ],
+ CCFLAGS =>'-DDEBUGGING -DPERL_GCC_PEDANTIC -ansi -pedantic -W
-Wno-sign-compare -Wall -Wno-cast-qual -Wpointer-arith -Wmissing-prototypes
-Wmissing-noreturn -Wdisabled-optimization -Wbad-function-cast',
DIR => [ ],
dynamic_lib => { OTHERLDFLAGS => "$::opt_g" },
clean => { FILES=> "\$(DISTVNAME) Perl.xsi t/zv*_*.t"
Is this patch something you find useful? If so, I can keep digging.
This is just from blowing through this for a couple of hours this
afternoon.
xoxo,
Andy
--
Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance
Index: DBI.xs
===================================================================
--- DBI.xs (.../DBI-1.48) (revision 17)
+++ DBI.xs (.../trunk) (revision 17)
@@ -62,22 +62,23 @@
static imp_xxh_t *dbih_getcom _((SV *h));
static imp_xxh_t *dbih_getcom2 _((SV *h, MAGIC **mgp));
static void dbih_clearcom _((imp_xxh_t *imp_xxh));
-static int dbih_logmsg _((imp_xxh_t *imp_xxh, char *fmt, ...));
-static SV *dbih_make_com _((SV *parent_h, imp_xxh_t *p_imp_xxh, char
*imp_class, STRLEN imp_size, STRLEN extra, SV *copy));
-static SV *dbih_make_fdsv _((SV *sth, char *imp_class, STRLEN
imp_size, char *col_name));
+static int dbih_logmsg _((imp_xxh_t *imp_xxh, const char *fmt,
...));
+static SV *dbih_make_com _((SV *parent_h, imp_xxh_t *p_imp_xxh, const
char *imp_class, STRLEN imp_size, STRLEN extra, SV *copy));
+static SV *dbih_make_fdsv _((SV *sth, const char *imp_class, STRLEN
imp_size, const char *col_name));
static AV *dbih_get_fbav _((imp_sth_t *imp_sth));
-static SV *dbih_event _((SV *h, char *name, SV*, SV*));
+static SV *dbih_event _((SV *h, const char *name, SV*, SV*));
static int dbih_set_attr_k _((SV *h, SV *keysv, int dbikey, SV
*valuesv));
static SV *dbih_get_attr_k _((SV *h, SV *keysv, int dbikey));
static int dbih_sth_bind_col _((SV *sth, SV *col, SV *ref, SV *attribs));
-static int set_err_char _((SV *h, imp_xxh_t *imp_xxh, char *err_c, IV
err_i, char *errstr, char *state, char *method));
+static int set_err_char _((SV *h, imp_xxh_t *imp_xxh, const char *err_c,
IV err_i, const char *errstr, const char *state, const char *method));
static int set_err_sv _((SV *h, imp_xxh_t *imp_xxh, SV *err, SV *errstr,
SV *state, SV *method));
static int quote_type _((int sql_type, int p, int s, int *base_type, void
*v));
-static int dbi_hash _((char *string, long i));
-static void dbih_dumphandle _((SV *h, char *msg, int level));
-static void dbih_dumpcom _((imp_xxh_t *imp_xxh, char *msg, int level));
+static int dbi_hash _((const char *string, long i));
+static void dbih_dumphandle _((SV *h, const char *msg, int level));
+static void dbih_dumpcom _((imp_xxh_t *imp_xxh, const char *msg, int
level));
char *neatsvpv _((SV *sv, STRLEN maxlen));
+SV * preparse(SV *dbh, const char *statement, IV ps_return, IV ps_accept, void
*foo);
DBISTATE_DECLARE;
@@ -94,7 +95,7 @@
U8 maxargs;
IV hidearg;
IV trace_level;
- char *usage_msg;
+ const char *usage_msg;
U32 flags;
} dbi_ima_t;
@@ -184,11 +185,12 @@
/* --- */
static void
-check_version(char *name, int dbis_cv, int dbis_cs, int need_dbixs_cv, int
drc_s,
+check_version(const char *name, int dbis_cv, int dbis_cs, int need_dbixs_cv,
int drc_s,
int dbc_s, int stc_s, int fdc_s)
{
dPERINTERP;
- char *msg = "you probably need to rebuild the DBD driver (or possibly the
DBI)";
+ static const char msg[] = "you probably need to rebuild the DBD driver (or
possibly the DBI)";
+ (void)need_dbixs_cv;
if (dbis_cv != DBISTATE_VERSION || dbis_cs != sizeof(*DBIS))
croak("DBI/DBD internal version mismatch (DBI is v%d/s%d, DBD %s
expected v%d/s%d) %s.\n",
DBISTATE_VERSION, sizeof(*DBIS), name, dbis_cv, dbis_cs, msg);
@@ -391,7 +393,7 @@
v = SvPV(nsv, len);
if (!SvUTF8(sv)) {
while(len-- > 0) { /* cleanup string (map control chars to ascii etc) */
- char c = v[len] & 0x7F; /* ignore top bit for multinational
chars */
+ const char c = v[len] & 0x7F; /* ignore top bit for
multinational chars */
if (!isPRINT(c) && !isSPACE(c))
v[len] = '.';
}
@@ -401,7 +403,7 @@
static int
-set_err_char(SV *h, imp_xxh_t *imp_xxh, char *err_c, IV err_i, char *errstr,
char *state, char *method)
+set_err_char(SV *h, imp_xxh_t *imp_xxh, const char *err_c, IV err_i, const
char *errstr, const char *state, const char *method)
{
char err_buf[28];
SV *err_sv, *errstr_sv, *state_sv, *method_sv;
@@ -514,7 +516,7 @@
static char *
-mkvname( HV *stash, char *item, int uplevel) /* construct a variable name
*/
+mkvname( HV *stash, const char *item, int uplevel) /* construct a variable
name */
{
STRLEN lna;
SV *sv = sv_newmortal();
@@ -532,7 +534,7 @@
static int
-dbi_hash(char *key, long type)
+dbi_hash(const char *key, long type)
{
if (type == 0) {
STRLEN klen = strlen(key);
@@ -546,7 +548,7 @@
else if (type == 1) { /* Fowler/Noll/Vo hash */
/* see http://www.isthe.com/chongo/tech/comp/fnv/ */
U32 hash = 0x811c9dc5;
- unsigned char *s = (unsigned char *)key; /* unsigned string */
+ const unsigned char *s = (unsigned char *)key; /* unsigned string */
while (*s) {
/* multiply by the 32 bit FNV magic prime mod 2^64 */
hash *= FNV_32_PRIME;
@@ -561,7 +563,7 @@
static int
-dbih_logmsg(imp_xxh_t *imp_xxh, char *fmt, ...)
+dbih_logmsg(imp_xxh_t *imp_xxh, const char *fmt, ...)
{
dPERINTERP;
va_list args;
@@ -572,6 +574,7 @@
#endif
(void) PerlIO_vprintf(DBIS->logfp, fmt, args);
va_end(args);
+ (void)imp_xxh;
return 1;
}
@@ -581,7 +584,7 @@
{
dPERINTERP;
STRLEN lna;
- char *filename;
+ const char *filename;
PerlIO *fp;
if (!file) /* no arg == no change */
return 0;
@@ -674,7 +677,7 @@
static SV *
-dbih_inner(SV *orv, char *what)
+dbih_inner(SV *orv, const char *what)
{ /* convert outer to inner handle else croak(what) if what is not null */
dPERINTERP;
MAGIC *mg;
@@ -833,11 +836,11 @@
static SV *
-dbih_make_fdsv(SV *sth, char *imp_class, STRLEN imp_size, char *col_name)
+dbih_make_fdsv(SV *sth, const char *imp_class, STRLEN imp_size, const char
*col_name)
{
dPERINTERP;
D_imp_sth(sth);
- STRLEN cn_len = strlen(col_name);
+ const STRLEN cn_len = strlen(col_name);
imp_fdh_t *imp_fdh;
SV *fdsv;
if (imp_size < sizeof(imp_fdh_t) || cn_len<10 ||
strNE("::fd",&col_name[cn_len-4]))
@@ -855,21 +858,22 @@
static SV *
-dbih_make_com(SV *p_h, imp_xxh_t *p_imp_xxh, char *imp_class, STRLEN imp_size,
STRLEN extra, SV* copy)
+dbih_make_com(SV *p_h, imp_xxh_t *p_imp_xxh, const char *imp_class, STRLEN
imp_size, STRLEN extra, SV* copy)
{
dPERINTERP;
- char *errmsg = "Can't make DBI com handle for %s: %s";
+ static const char errmsg[] = "Can't make DBI com handle for %s: %s";
HV *imp_stash;
SV *dbih_imp_sv;
imp_xxh_t *imp;
STRLEN memzero_size;
+ (void)extra;
if ( (imp_stash = gv_stashpv(imp_class, FALSE)) == NULL)
croak(errmsg, imp_class, "unknown package");
if (imp_size == 0) {
/* get size of structure to allocate for common and imp specific data
*/
- char *imp_size_name = mkvname(imp_stash, "imp_data_size", 0);
+ const char *imp_size_name = mkvname(imp_stash, "imp_data_size", 0);
imp_size = SvIV(perl_get_sv(imp_size_name, 0x05));
if (imp_size == 0) {
imp_size = sizeof(imp_sth_t);
@@ -1051,19 +1055,19 @@
static void
-dbih_dumphandle(SV *h, char *msg, int level)
+dbih_dumphandle(SV *h, const char *msg, int level)
{
D_imp_xxh(h);
dbih_dumpcom(imp_xxh, msg, level);
}
static void
-dbih_dumpcom(imp_xxh_t *imp_xxh, char *msg, int level)
+dbih_dumpcom(imp_xxh_t *imp_xxh, const char *msg, int level)
{
dPERINTERP;
SV *flags = sv_2mortal(newSVpv("",0));
STRLEN lna;
- char *pad = " ";
+ static const char pad[] = " ";
if (!msg)
msg = "dbih_dumpcom";
PerlIO_printf(DBILOGFP," %s (%sh 0x%lx, com 0x%lx, imp %s):\n",
@@ -1098,12 +1102,12 @@
PerlIO_printf(DBILOGFP,"%s LongReadLen %ld\n", pad,
(long)DBIc_LongReadLen(imp_xxh));
if (DBIc_TYPE(imp_xxh) <= DBIt_DB) {
- imp_dbh_t *imp_dbh = (imp_dbh_t*)imp_xxh;
+ const imp_dbh_t *imp_dbh = (imp_dbh_t*)imp_xxh;
if (DBIc_CACHED_KIDS(imp_dbh))
PerlIO_printf(DBILOGFP,"%s CachedKids %d\n", pad,
(int)HvKEYS(DBIc_CACHED_KIDS(imp_dbh)));
}
if (DBIc_TYPE(imp_xxh) == DBIt_ST) {
- imp_sth_t *imp_sth = (imp_sth_t*)imp_xxh;
+ const imp_sth_t *imp_sth = (imp_sth_t*)imp_xxh;
PerlIO_printf(DBILOGFP,"%s NUM_OF_FIELDS %d\n", pad,
DBIc_NUM_FIELDS(imp_sth));
PerlIO_printf(DBILOGFP,"%s NUM_OF_PARAMS %d\n", pad,
DBIc_NUM_PARAMS(imp_sth));
}
@@ -1130,7 +1134,7 @@
int dump = FALSE;
int debug = DBIS_TRACE_LEVEL;
int auto_dump = (debug >= 6);
- imp_xxh_t *parent_xxh = DBIc_PARENT_COM(imp_xxh);
+ imp_xxh_t * const parent_xxh = DBIc_PARENT_COM(imp_xxh);
/* Note that we're very much on our own here. DBIc_MY_H(imp_xxh) almost
*/
/* certainly points to memory which has been freed. Don't use it!
*/
@@ -1331,6 +1335,10 @@
/* false implying that binding as a string should be okay. */
/* The true value is either SQL_INTEGER or SQL_DOUBLE which */
/* can be used as a hint if desired. */
+ (void)p;
+ (void)s;
+ (void)t;
+ (void)v;
switch(sql_type) {
case SQL_INTEGER:
case SQL_SMALLINT:
@@ -1358,11 +1366,12 @@
dTHR;
D_imp_xxh(h);
STRLEN keylen;
- char *key = SvPV(keysv, keylen);
- int htype = DBIc_TYPE(imp_xxh);
+ const char *key = SvPV(keysv, keylen);
+ const int htype = DBIc_TYPE(imp_xxh);
int on = (SvTRUE(valuesv));
int internal = 1; /* DBIh_IN_PERL_DBD(imp_xxh); -- for DBD's in perl */
int cacheit = 0;
+ (void)dbikey;
if (DBIS_TRACE_LEVEL >= 3)
PerlIO_printf(DBILOGFP," STORE %s %s => %s\n",
@@ -1443,7 +1452,7 @@
cacheit = 1; /* child copy setup by dbih_setup_handle() */
}
else if (strEQ(key, "Profile")) {
- char *dbi_class = "DBI::Profile";
+ static const char dbi_class[] = "DBI::Profile";
if (on && (!SvROK(valuesv) || (SvTYPE(SvRV(valuesv)) != SVt_PVHV)) ) {
/* not a hash ref so use DBI::Profile to work out what to do */
dTHR;
@@ -1592,6 +1601,7 @@
int i;
SV *sv;
SV **svp;
+ (void)dbikey;
/* DBI quick_FETCH will service some requests (e.g., cached values)
*/
@@ -1905,12 +1915,16 @@
static SV *
-dbih_event(SV *hrv, char *evtype, SV *a1, SV *a2)
+dbih_event(SV *hrv, const char *evtype, SV *a1, SV *a2)
{
/* We arrive here via DBIh_EVENT* macros (see DBIXS.h) called from */
/* DBD driver C code OR $h->event() method (in DBD::_::common) */
/* XXX VERY OLD INTERFACE/CONCEPT MAY GO SOON */
/* OR MAY EVOLVE INTO A WAY TO HANDLE 'SUCCESS_WITH_INFO'/'WARNINGS' from
db */
+ (void)hrv;
+ (void)evtype;
+ (void)a1;
+ (void)a2;
return &sv_undef;
}
@@ -2020,7 +2034,7 @@
static void
-clear_cached_kids(SV *h, imp_xxh_t *imp_xxh, char *meth_name, int trace_level)
+clear_cached_kids(SV *h, imp_xxh_t *imp_xxh, const char *meth_name, int
trace_level)
{
dPERINTERP;
if (DBIc_TYPE(imp_xxh) <= DBIt_DB &&
DBIc_CACHED_KIDS((imp_drh_t*)imp_xxh)) {
@@ -2060,7 +2074,7 @@
}
static void
-dbi_profile(SV *h, imp_xxh_t *imp_xxh, char *statement, SV *method, double t1,
double t2)
+dbi_profile(SV *h, imp_xxh_t *imp_xxh, const char *statement, SV *method,
double t1, double t2)
{
#define DBIprof_MAX_PATH_ELEM 9 /* STATEMENT->$Statement->$method */
#define DBIprof_COUNT 0
@@ -2072,7 +2086,7 @@
#define DBIprof_LAST_CALLED 6
#define DBIprof_max_index 6
double ti = t2 - t1;
- char *path[DBIprof_MAX_PATH_ELEM+1];
+ const char *path[DBIprof_MAX_PATH_ELEM+1];
int idx = -1;
STRLEN lna;
SV *profile;
@@ -2080,8 +2094,8 @@
AV *av;
HV *h_hv;
- int call_depth = DBIc_CALL_DEPTH(imp_xxh);
- int parent_call_depth = DBIc_PARENT_COM(imp_xxh) ?
DBIc_CALL_DEPTH(DBIc_PARENT_COM(imp_xxh)) : 0;
+ const int call_depth = DBIc_CALL_DEPTH(imp_xxh);
+ const int parent_call_depth = DBIc_PARENT_COM(imp_xxh) ?
DBIc_CALL_DEPTH(DBIc_PARENT_COM(imp_xxh)) : 0;
/* Only count calls originating from the application code */
/* *MAY* be made configurable later */
/* XXX BEWARE that if nested call profile data is merged */
@@ -2128,7 +2142,7 @@
len = av_len(av); /* -1=empty, 0=one element */
for ( ;(idx-1) <= len && idx < DBIprof_MAX_PATH_ELEM; ++idx) {
SV *pathsv = AvARRAY(av)[idx-1];
- char *p;
+ const char *p;
switch(SvIOK(pathsv) ? SvIV(pathsv) : 0) {
case -2100000001:
p = statement;
@@ -2294,9 +2308,9 @@
int call_depth;
double profile_t1 = 0.0;
- char *meth_name = GvNAME(CvGV(cv));
- dbi_ima_t *ima = (dbi_ima_t*)CvXSUBANY(cv).any_ptr;
- U32 ima_flags = (ima) ? ima->flags : 0;
+ const char *meth_name = GvNAME(CvGV(cv));
+ const dbi_ima_t *ima = (dbi_ima_t*)CvXSUBANY(cv).any_ptr;
+ const U32 ima_flags = (ima) ? ima->flags : 0;
imp_xxh_t *imp_xxh = NULL;
SV *imp_msv = Nullsv;
SV *qsv = Nullsv; /* quick result from a shortcut method */
@@ -2361,7 +2375,7 @@
imp_xxh = dbih_getcom2(h, 0); /* get common Internal Handle Attributes
*/
if (!imp_xxh) {
if (strEQ(meth_name, "can")) { /* ref($h)->can("foo") */
- char *can_meth = SvPV(st1,lna);
+ const char *can_meth = SvPV(st1,lna);
SV *rv = &PL_sv_undef;
GV *gv = gv_fetchmethod_autoload(gv_stashsv(orig_h,FALSE),
can_meth, FALSE);
if (gv && isGV(gv))
@@ -2414,7 +2428,7 @@
if (ima_flags & IMA_STUB) {
if (*meth_name == 'c' && strEQ(meth_name,"can")) {
- char *can_meth = SvPV(st1,lna);
+ const char *can_meth = SvPV(st1,lna);
SV *dbi_msv = Nullsv;
SV *imp_msv; /* handle implementors method (GV or CV) */
if ( (imp_msv =
(SV*)gv_fetchmethod_autoload(DBIc_IMP_STASH(imp_xxh), can_meth, FALSE)) ) {
@@ -2461,7 +2475,7 @@
}
if (ima_flags & IMA_HAS_USAGE) {
- char *err = NULL;
+ const char *err = NULL;
char msg[200];
if (ima->minargs && (items < ima->minargs
@@ -2559,7 +2573,7 @@
/* Shortcut for fetching attributes to bypass method call overheads */
if ( (is_FETCH = (*meth_name=='F' && strEQ(meth_name,"FETCH"))) &&
!DBIc_COMPAT(imp_xxh)) {
STRLEN kl;
- char *key = SvPV(st1, kl);
+ const char *key = SvPV(st1, kl);
SV **attr_svp;
if (*key != '_' && (attr_svp=hv_fetch((HV*)SvRV(h), key, kl, 0))) {
qsv = *attr_svp;
@@ -2599,7 +2613,7 @@
if (trace_level >= 2) {
PerlIO *logfp = DBILOGFP;
/* Full pkg method name (or just meth_name for ANON CODE) */
- char *imp_meth_name = (imp_msv && isGV(imp_msv)) ? GvNAME(imp_msv)
: meth_name;
+ const char *imp_meth_name = (imp_msv && isGV(imp_msv)) ?
GvNAME(imp_msv) : meth_name;
HV *imp_stash = DBIc_IMP_STASH(imp_xxh);
PerlIO_printf(logfp, "%c -> %s ",
call_depth>1 ? '0'+call_depth-1 : (dirty?'!':' '),
imp_meth_name);
@@ -2711,8 +2725,8 @@
&& (!DBIc_PARENT_COM(imp_xxh) ||
DBIc_CALL_DEPTH(DBIc_PARENT_COM(imp_xxh)) < 1))
) {
PerlIO *logfp = DBILOGFP;
- int is_fetch = (*meth_name=='f' && DBIc_TYPE(imp_xxh)==DBIt_ST &&
strnEQ(meth_name,"fetch",5));
- int row_count = (is_fetch) ? DBIc_ROW_COUNT((imp_sth_t*)imp_xxh) : 0;
+ const int is_fetch = (*meth_name=='f' && DBIc_TYPE(imp_xxh)==DBIt_ST
&& strnEQ(meth_name,"fetch",5));
+ const int row_count = (is_fetch) ? DBIc_ROW_COUNT((imp_sth_t*)imp_xxh)
: 0;
if (is_fetch && row_count>=2 && trace_level<=1 && SvOK(ST(0))) {
/* skip the 'middle' rows to reduce output */
goto skip_meth_return_trace;
@@ -2860,8 +2874,8 @@
) {
SV *msg;
SV **statement_svp = NULL;
- int is_warning = (!SvTRUE(err_sv) && strlen(SvPV_nolen(err_sv))==1);
- char *err_meth_name = meth_name;
+ const int is_warning = (!SvTRUE(err_sv) &&
strlen(SvPV_nolen(err_sv))==1);
+ const char *err_meth_name = meth_name;
char intro[200];
if (*meth_name=='s' && strEQ(meth_name,"set_err")) {
@@ -3015,7 +3029,7 @@
#define PS_return(flag) DBIbf_has(ps_return,(flag))
SV *
-preparse(SV *dbh, char *statement, IV ps_return, IV ps_accept, void *foo)
+preparse(SV *dbh, const char *statement, IV ps_return, IV ps_accept, void *foo)
{
D_imp_xxh(dbh);
/*
@@ -3054,10 +3068,13 @@
char in_quote = '\0';
char in_comment = '\0';
char rt_comment = '\0';
- char *src, *start, *dest;
- char *style = "", *laststyle = '\0';
+ char *dest, *start;
+ const char *src;
+ const char *style = "", *laststyle = '\0';
SV *new_stmt_sv;
+ (void)foo;
+
if (!(ps_return | DBIpp_ph_XX)) { /* no return ph type specified */
ps_return |= ps_accept | DBIpp_ph_XX; /* so copy from ps_accept */
}
@@ -3232,7 +3249,7 @@
}
}
else if (isDIGIT(*src)) { /* :1 */
- int pln = atoi(src);
+ const int pln = atoi(src);
style = ":1";
if (PS_return(DBIpp_ph_cn)) { /* ':1'->':p1' */
@@ -3324,7 +3341,8 @@
BOOT:
- items = items; /* avoid 'unused variable' warning */
+ (void)cv;
+ (void)items; /* avoid 'unused variable' warning */
dbi_bootinit(NULL);
@@ -3418,6 +3436,7 @@
_clone_dbis()
CODE:
dPERINTERP;
+ (void)cv;
dbi_bootinit(DBIS);
@@ -3428,6 +3447,7 @@
SV * parent
SV * imp_datasv
CODE:
+ (void)cv;
dbih_setup_handle(sv, imp_class, parent, SvOK(imp_datasv) ? imp_datasv :
Nullsv);
ST(0) = &sv_undef;
@@ -3437,6 +3457,7 @@
SV * sv
CODE:
D_imp_xxh(sv);
+ (void)cv;
ST(0) = sv_mortalcopy(DBIc_IMP_DATA(imp_xxh)); /* okay if NULL */
@@ -3448,6 +3469,7 @@
D_imp_xxh(sv);
SV *ih = sv_mortalcopy( dbih_inner(sv, "_handles") );
SV *oh = sv_2mortal(newRV((SV*)DBIc_MY_H(imp_xxh))); /* XXX dangerous */
+ (void)cv;
EXTEND(SP, 2);
PUSHs(oh); /* returns outer handle then inner */
PUSHs(ih);
@@ -3459,13 +3481,15 @@
U32 maxlen
CODE:
ST(0) = sv_2mortal(newSVpv(neatsvpv(sv, maxlen), 0));
+ (void)cv;
int
hash(key, type=0)
- char *key
+ const char *key
long type
CODE:
+ (void)cv;
RETVAL = dbi_hash(key, type);
OUTPUT:
RETVAL
@@ -3475,6 +3499,7 @@
PPCODE:
int i;
EXTEND(SP, items);
+ (void)cv;
for(i=0; i < items ; ++i) {
SV *sv = ST(i);
if (!SvOK(sv) || (SvPOK(sv) && SvCUR(sv)==0))
@@ -3488,7 +3513,7 @@
void
_install_method(dbi_class, meth_name, file, attribs=Nullsv)
- char * dbi_class
+ const char * dbi_class
char * meth_name
char * file
SV * attribs
@@ -3500,7 +3525,8 @@
CV *cv;
SV **svp;
dbi_ima_t *ima = NULL;
- dbi_class = dbi_class; /* avoid 'unused variable' warning
*/
+ (void)dbi_class;
+ (void)cv; /* avoid 'unused variable' warning */
if (strnNE(meth_name, "DBI::", 5)) /* XXX m/^DBI::\w+::\w+$/ */
croak("install_method %s: invalid class", meth_name);
@@ -3590,9 +3616,10 @@
void
dump_handle(sv, msg="DBI::dump_handle", level=0)
SV * sv
- char * msg
+ const char *msg
int level
CODE:
+ (void)cv;
dbih_dumphandle(sv, msg, level);
@@ -3603,6 +3630,7 @@
CODE:
{
dPERINTERP;
+ (void)cv;
PerlIO_printf(DBILOGFP, "DBI::_svdump(%s)", neatsvpv(sv,0));
#ifdef DEBUGGING
sv_dump(sv);
@@ -3624,6 +3652,7 @@
CODE:
D_imp_xxh(h);
STRLEN lna = 0;
+ (void)cv;
dbi_profile(h, imp_xxh,
SvOK(statement) ? SvPV(statement,lna) : Nullch,
SvROK(method) ? SvRV(method) : method,
@@ -3639,6 +3668,7 @@
SV * dest
CODE:
{
+ (void)cv;
if (!SvROK(dest) || SvTYPE(SvRV(dest)) != SVt_PVAV)
croak("dbi_profile_merge(%s,...) not an array reference",
neatsvpv(dest,0));
/* items==2 for dest + 1 arg, ST(0) is dest, ST(1) is first arg */
@@ -3695,7 +3725,7 @@
ST(0) = DBIc_STATE_adjust(imp_xxh, state);
}
else if (type == '$') { /* lookup scalar variable in implementors stash */
- char *vname = mkvname(DBIc_IMP_STASH(imp_xxh), meth, 0);
+ const char *vname = mkvname(DBIc_IMP_STASH(imp_xxh), meth, 0);
SV *vsv = perl_get_sv(vname, 1);
ST(0) = sv_mortalcopy(vsv);
}
@@ -3761,6 +3791,7 @@
end up being DESTROY's before the driver has had a chance to 're-setup'
the data. See dbih_setup_handle()
*/
+ (void)cv;
if (DBIc_TYPE(imp_xxh) <= DBIt_DB && DBIc_CACHED_KIDS((imp_dbh_t*)imp_xxh))
clear_cached_kids(h, imp_xxh, "take_imp_data", 0);
if (DBIc_KIDS(imp_xxh)) { /* safety check, may be relaxed later to
DBIc_ACTIVE_KIDS */
@@ -3795,6 +3826,7 @@
CODE:
D_imp_sth(sth);
AV *av = dbih_get_fbav(imp_sth);
+ (void)cv;
ST(0) = sv_2mortal(newRV((SV*)av));
void
@@ -3806,7 +3838,9 @@
int i;
AV *src_av;
AV *dst_av = dbih_get_fbav(imp_sth);
- int num_fields = AvFILL(dst_av)+1;
+ const int num_fields = AvFILL(dst_av)+1;
+ (void)cv;
+
if (!SvROK(src_rv) || SvTYPE(SvRV(src_rv)) != SVt_PVAV)
croak("_set_fbav(%s): not an array ref", neatsvpv(src_rv,0));
src_av = (AV*)SvRV(src_rv);
@@ -3831,6 +3865,7 @@
CODE:
DBD_ATTRIBS_CHECK("bind_col", sth, attribs);
ST(0) = boolSV(dbih_sth_bind_col(sth, col, ref, attribs));
+ (void)cv;
void
@@ -3886,12 +3921,13 @@
SV *
fetchrow_hashref(sth, keyattrib=Nullch)
SV * sth
- char * keyattrib
+ const char *keyattrib
PREINIT:
SV *rowavr;
SV *ka_rv;
D_imp_sth(sth);
CODE:
+ (void)cv;
PUSHMARK(sp);
XPUSHs(sth);
PUTBACK;
@@ -3915,7 +3951,7 @@
if (SvROK(rowavr) && SvTYPE(SvRV(rowavr)) == SVt_PVAV) {
int i;
AV *rowav = (AV*)SvRV(rowavr);
- int num_fields = AvFILL(rowav)+1;
+ const int num_fields = AvFILL(rowav)+1;
HV *hv;
AV *ka_av;
if (!(SvROK(ka_rv) && SvTYPE(SvRV(ka_rv))==SVt_PVAV)) {
@@ -3930,7 +3966,7 @@
for (i=0; i < num_fields; ++i) { /* honor the original order as
sent by the database */
STRLEN len;
SV **field_name_svp = av_fetch(ka_av, i, 1);
- char *field_name = SvPV(*field_name_svp, len);
+ const char *field_name = SvPV(*field_name_svp, len);
hv_store(hv, field_name, len, newSVsv((SV*)(AvARRAY(rowav)[i])), 0);
}
RETVAL = newRV((SV*)hv);
@@ -3955,7 +3991,7 @@
CODE:
int num_fields;
if (CvDEPTH(cv) == 99) {
- ix = ix; /* avoid 'unused variable' warning' */
+ (void)ix; /* avoid 'unused variable' warning' */
croak("Deep recursion. Probably fetch-fetchrow-fetch loop.");
}
PUSHMARK(sp);
@@ -3983,8 +4019,9 @@
SV * sth
CODE:
D_imp_sth(sth);
- IV rows = DBIc_ROW_COUNT(imp_sth);
+ const IV rows = DBIc_ROW_COUNT(imp_sth);
ST(0) = sv_2mortal(newSViv(rows));
+ (void)cv;
void
@@ -3994,6 +4031,7 @@
D_imp_sth(sth);
DBIc_ACTIVE_off(imp_sth);
ST(0) = &sv_yes;
+ (void)cv;
MODULE = DBI PACKAGE = DBD::_::common
@@ -4004,7 +4042,8 @@
SV * h
CODE:
/* DESTROY defined here just to avoid AUTOLOAD */
- h = h;
+ (void)cv;
+ (void)h;
ST(0) = &sv_undef;
@@ -4017,6 +4056,7 @@
ST(0) = &sv_yes;
if (!dbih_set_attr_k(h, keysv, 0, valuesv))
ST(0) = &sv_no;
+ (void)cv;
void
@@ -4025,6 +4065,7 @@
SV * keysv
CODE:
ST(0) = dbih_get_attr_k(h, keysv, 0);
+ (void)cv;
void
@@ -4032,6 +4073,7 @@
SV * h
CODE:
D_imp_xxh(h);
+ (void)cv;
ST(0) = sv_mortalcopy(DBIc_IMP_DATA(imp_xxh));
@@ -4041,6 +4083,7 @@
CODE:
D_imp_xxh(h);
SV *errsv = DBIc_ERR(imp_xxh);
+ (void)cv;
ST(0) = sv_mortalcopy(errsv);
void
@@ -4050,6 +4093,7 @@
D_imp_xxh(h);
STRLEN lna;
SV *state = DBIc_STATE(imp_xxh);
+ (void)cv;
ST(0) = DBIc_STATE_adjust(imp_xxh, state);
void
@@ -4060,6 +4104,7 @@
SV *errstr = DBIc_ERRSTR(imp_xxh);
SV *err;
/* If there's no errstr but there is an err then use err */
+ (void)cv;
if (!SvTRUE(errstr) && (err=DBIc_ERR(imp_xxh)) && SvTRUE(err))
errstr = err;
ST(0) = sv_mortalcopy(errstr);
@@ -4077,6 +4122,7 @@
{
D_imp_xxh(h);
SV **sem_svp;
+ (void)cv;
if (DBIc_has(imp_xxh, DBIcf_HandleSetErr) && SvREADONLY(method))
method = sv_mortalcopy(method); /* HandleSetErr may want to change it */
@@ -4109,8 +4155,9 @@
ALIAS:
debug = 1
CODE:
- ix = ix; /* avoid 'unused variable' warning */
RETVAL = set_trace(h, level, file);
+ (void)cv; /* Unused variables */
+ (void)ix;
OUTPUT:
RETVAL
@@ -4118,7 +4165,7 @@
void
trace_msg(sv, msg, this_trace=1)
SV *sv
- char *msg
+ const char *msg
int this_trace
PREINIT:
int current_trace;
@@ -4126,6 +4173,7 @@
CODE:
{
dPERINTERP;
+ (void)cv;
if (SvROK(sv)) {
D_imp_xxh(sv);
current_trace = DBIc_TRACE_LEVEL(imp_xxh);
@@ -4150,8 +4198,9 @@
SV * h
CODE:
/* fallback esp for $DBI::rows after $drh was last used */
- if (0) h = h; /* avoid unused variable warning */
ST(0) = sv_2mortal(newSViv(-1));
+ (void)h;
+ (void)cv;
void
@@ -4167,6 +4216,7 @@
SV *h2i = dbih_inner(rh2, "swap_inner_handle");
SV *h1 = (rh1 == h1i) ? (SV*)DBIc_MY_H(imp_xxh1) : SvRV(rh1);
SV *h2 = (rh2 == h2i) ? (SV*)DBIc_MY_H(imp_xxh2) : SvRV(rh2);
+ (void)cv;
if (DBIc_TYPE(imp_xxh1) != DBIc_TYPE(imp_xxh2)) {
char buf[99];
sprintf(buf, "Can't swap_inner_handle between %sh and %sh",
@@ -4204,5 +4254,6 @@
/* ignore 'cast increases required alignment' warning */
imp_xxh_t *imp_xxh = (imp_xxh_t*)SvPVX(SvRV(imp_xxh_rv));
DBIS->clearcom(imp_xxh);
+ (void)cv;
# end
Index: DBIXS.h
===================================================================
--- DBIXS.h (.../DBI-1.48) (revision 17)
+++ DBIXS.h (.../trunk) (revision 17)
@@ -386,7 +386,7 @@
#define DBISTATE_VERSION 94 /* Must change whenever dbistate_t does */
/* this must be the first member in structure */
- void (*check_version) _((char *name,
+ void (*check_version) _((const char *name,
int dbis_cv, int dbis_cs, int need_dbixs_cv,
int drc_s, int dbc_s, int stc_s, int fdc_s));
@@ -403,22 +403,22 @@
char * (*neat_svpv) _((SV *sv, STRLEN maxlen));
imp_xxh_t * (*getcom) _((SV *h)); /* see DBIh_COM macro */
void (*clearcom) _((imp_xxh_t *imp_xxh));
- SV * (*event) _((SV *h, char *name, SV*, SV*));
+ SV * (*event) _((SV *h, const char *name, SV*, SV*));
int (*set_attr_k) _((SV *h, SV *keysv, int dbikey, SV *valuesv));
SV * (*get_attr_k) _((SV *h, SV *keysv, int dbikey));
AV * (*get_fbav) _((imp_sth_t *imp_sth));
- SV * (*make_fdsv) _((SV *sth, char *imp_class, STRLEN imp_size,
char *col_name));
+ SV * (*make_fdsv) _((SV *sth, const char *imp_class, STRLEN
imp_size, const char *col_name));
int (*bind_as_num) _((int sql_type, int p, int s, int *t, void
*v));
- int (*hash) _((char *string, long i));
+ int (*hash) _((const char *string, long i));
SV * (*preparse) _((SV *sth, char *statement, IV ps_return, IV
ps_accept, void *foo));
SV *neatsvpvlen; /* only show dbgpvlen chars when debugging pv's
*/
PerlInterpreter * thr_owner; /* thread that owns this dbistate
*/
- int (*logmsg) _((imp_xxh_t *imp_xxh, char *fmt, ...));
+ int (*logmsg) _((imp_xxh_t *imp_xxh, const char *fmt, ...));
int (*set_err_sv) _((SV *h, imp_xxh_t *imp_xxh, SV *err, SV
*errstr, SV *state, SV *method));
- int (*set_err_char) _((SV *h, imp_xxh_t *imp_xxh, char *err, IV
err_i, char *errstr, char *state, char *method));
+ int (*set_err_char) _((SV *h, imp_xxh_t *imp_xxh, const char *err,
IV err_i, const char *errstr, const char *state, const char *method));
int (*bind_col) _((SV *sth, SV *col, SV *ref, SV *attribs));
void *pad2[5];
