On Wed, Jun 22, 2005 at 03:00:31AM -0700, Peter Scott wrote:
> On Tue, 21 Jun 2005 21:42:42 +0100, Tim Bunce wrote:
>
> > On Tue, Jun 21, 2005 at 06:46:03AM -0700, Peter Scott wrote:
> >> - $dbh->connected($dsn, $user, $pass, $attr) if ref $dbh ne
> >> 'DBI::db';
> >> + # We'll normalize the dsn first
> >> + $dbh->connected("dbi:$driver($driver_attrib_spec):$dsn",
> >> @orig_args[1..3])
> >> + if ref $dbh ne 'DBI::db';
> >
> > Why not just
> >
> > $dbh->connected(@orig_args) if ...
>
> I'd thought about that. The arguments could either reflect "This is how I
> was called" or "This is what I did." And it seems that the subclass would
> need to duplicate the DBI_AUTOPROXY logic if I didn't do the latter.
> "connected" sounds like "connected as..." to me.
>
> Hmm. The same argument could apply to $user and $pass being set via
> default_user(), though. I think that should be
>
> $dbh->connected("dbi:$driver($driver_attrib_spec):$dsn", $user, $pass,
> $orig_args[3]) if ...
>
> But if that logic's sounding too contorted I'd have no problem with just
> passing @orig_args.
I'll go with @orig_args. If DBI_AUTOPROXY is being used then
$dbh->connected will be called on the server side, in which case the
original args make more sense. I'll duck the $user/$pass issue.
Done.
Tim.
