On Fri, Feb 02, 2007 at 12:13:19PM +0000, Tielman de Villiers wrote:
> On Fri, 2007-02-02 at 11:50 +0000, Tim Bunce wrote:
> > You can download it from:
> >
> > http://homepage.mac.com/tim.bunce/.Public/perl/DBI-1.54-RC2.tar.gz
> >
> > =head2 Changes in DBI 1.54 (svn rev 8791), 2nd February 2007
> >
>
> > Same as RC1 except fixes a binary compatibility problem with compiled
> > drivers
> > (so this is safe to install) and removes dependency on Class::Accessor.
> >
> > I'd be grateful for any testing, and especially for feedback on DBD::Gofer
> > (previously mentioned as DBD::Forward, but DBD::Gofer is a much better name
> > :)
> >
>
> uname -a
> Linux lmn12448 2.6.17-10-386 #2 Tue Dec 5 22:26:18 UTC 2006 i686
> GNU/Linux
>
> perl -v
> This is perl, v5.8.8 built for i486-linux-gnu-thread-multi
>
> make test errors
>
> t/zvg_13taint.............Can't locate t/13taint.t in @INC (@INC
> contains: /home/tvilliers/usr/src/DBI-1.54/blib/lib
> /home/tvilliers/usr/src/DBI-1.54/blib/arch
> /home/tvilliers/usr/lib/perl5/5.8.7 /home/tvilliers/usr/lib/perl5/5.8.7
> /home/tvilliers/usr/lib/perl5 /etc/perl /usr/local/lib/perl/5.8.8
> /usr/local/share/perl/5.8.8 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.8
> /usr/share/perl/5.8 /usr/local/lib/site_perl /usr/local/lib/perl/5.8.7
> /usr/local/share/perl/5.8.7) at t/zvg_13taint.t line 3.
On Fri, Feb 02, 2007 at 09:19:11AM -0600, Scott T. Hildreth wrote:
>
> Same errors on FreeBSD 6.1
> This is perl, v5.8.7 built for i386-freebsd-thread-multi
On Fri, Feb 02, 2007 at 09:22:11AM -0600, Scott T. Hildreth wrote:
>
> FreeBSD 6.1
> This is perl, v5.8.8 built for i386-freebsd
Umm. So we have
5.8.8 i486-linux-gnu-thread-multi = fail
5.8.8 i386-freebsd = ok
5.8.7 i386-freebsd-thread-multi = fail
5.8.6 darwin-thread-multi-2level = ok
We didn't have the problem with DBI 1.53 because the taint tests were
embedded in t/10examp.t (which had -T option on the first line)
and the t/zv* wrapper didn't (which was a bug that's fixed in 1.54).
t/zvg_13taint looks like
#!perl -wT
$ENV{DBI_AUTOPROXY} = 'dbi:Gofer:transport=null';
require 't/13taint.t'; # or warn $!;
die if $@;
exit 0
I think the problem is that the -T option causes perl to ignore the
PERL5LIB env var. What I don't quite see is how it works for some people.
Anyway, I've appended a patch. Let me know how it works for you.
(You'll need to do a "perl Makefile.PL" after applying the patch.)
Tim.
--- lib/DBI/DBD.pm (revision 8784)
+++ lib/DBI/DBD.pm (working copy)
@@ -3047,9 +3047,7 @@
print PPT "#!$v_perl\n";
print PPT "use threads;\n" if $usethr;
print PPT "$_;\n" foreach @{$v_info->{add}};
- print PPT "require 't/$test'; # or warn \$!;\n";
- print PPT 'die if $@;'."\n";
- print PPT "exit 0\n";
+ print PPT "require './t/$test'; # or warn \$!;\n";
close PPT or warn "Error writing $v_test: $!";
}
}
