On Thu, 2007-03-08 at 12:23 -0600, Scott T. Hildreth wrote:
> On Wed, 2007-03-07 at 16:58 -0600, Scott T. Hildreth wrote:
> > mysql Ver 12.21 Distrib 4.0.15, for suse-linux (i686)
> >
> > ... So my client is not >= to SQL_STATE_VERSION, but dbdimp.c
> > still has do_error accepting a sqlstate param,
> >
> > void do_error(SV* h, int rc, const char* what, const char* sqlstate)
> >
> > causing this compile error,
> >
> > dbdimp.c:1269: error: conflicting types for `mysql_dr_error'
> > dbdimp.h:288: error: previous declaration of `mysql_dr_error'
> > dbdimp.c: In function `mysql_st_fetch':
> > dbdimp.c:3419: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c:3583: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c: In function `mysql_st_FETCH_internal':
> > dbdimp.c:3915: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c:3929: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c: In function `mysql_bind_ph':
> > dbdimp.c:4244: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c:4271: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c:4283: error: too few arguments to function `mysql_dr_error'
> > dbdimp.c: In function `mysql_db_reconnect':
> > dbdimp.c:4445: error: too few arguments to function `mysql_dr_error'
> > make: *** [dbdimp.o] Error 1
>
> Well I put the below #if's around all the do_error calls in dbdimp.c
> and got dbdimp.c to compile. Now mysql.xs needs these #if's. Before
> I add them, I wanted know if there is a better way of doing this or
> is this the right way to fix the error?
>
>
> #if MYSQL_VERSION_ID >= SQL_STATE_VERSION
> , {NULL or mysql_sqlstate());
> #else
> );
> #endif
>
>
I went ahead and added the #if's to mysql.xs, everything compiled.
Most the tests pass,
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/20createdrop.t 6 1 5
t/80procs.t 255 65280 32 44 11-32
t/prepare_noerror.t 3 1 2
t/utf8.t 15 2 6 11
2 tests skipped.
Failed 4/27 test scripts. 26/575 subtests failed.
Files=27, Tests=575, 5 wallclock secs ( 1.39 cusr + 0.29 csys = 1.68
CPU)
> Thanks.
>
> >
> > I can upgrade my client, just thought you should be aware of the error.
> >
> >
> > On Sat, 2007-03-03 at 22:12 -0500, Patrick Galbraith wrote:
> > > Dear DBD::mysql users and developers,
> > >
> > > I'm pleased to announce the release of DBD::mysql 4.003! This release
> > > contains
> > > various fixes including:
> > >
> > > * Fix re-exec of Makefile.PL when forcing $ENV{LANG} to 'C'. (RT #25233,
> > > reported by Slaven Rezic)
> > > * Rewrote table_info method to support all arguments (previously it would
> > > only ever return all of the tables in the current database, no matter
> > > what
> > > was specified)
> > > * Fixed $DBD::mysql::VERSION to be a string instead of a float, which
> > > caused
> > > problems for certain locales
> > > * Fixed bug #23974. $dbh->column_info now returns empty arrayref upon
> > > table
> > > not existing. Much thanks to Tim Bunce for help fixing the problem in
> > > mysql.pm vs. dbdimp.c
> > > * Removed #ifdefs for do error (sqlstate being passed as last arg
> > > depending on
> > > version)
> > > * Fixed insertid test to work with auto_increment_increment replication
> > > setup.
> > > * Patch from Tim Bunce fixing do() not set $dbh->{Statement} attribute,
> > > which prevented DBD::Profile from giving correct results for calls to
> > > do()
> > > and causing ShowErrorStatement to possibly report the wrong statement
> > > in the
> > > error message
> > > * Patch from Tim Bunce clearing out the sth attribute cache when switching
> > > between result, sets which prevented the adjustedment of NUM_OF_FIELDS
> > > * Cleanup of several unused variables
> > > * Added support for wildcards in last argument of column_info().
> > > * Add mysql_is_auto_increment to results of column_info(). (Bug #26603,
> > > original patch from Dave Rolsky)
> > > * Return the correct table type for both tables and views from the
> > > table_info()
> > > method. (Bug #26603, original patch from Dave Rolsky)
> > > * Add implementation of foreign_key_info() (Bug #26604, original patch
> > > from
> > > Dave Rolsky, and final implementation based on Connector/J code)
> > >
> > > Note: you may notice that the version went from 4.001 to 4.003. That's
> > > because there
> > > was an issue with the 4.002 distribution file that needed to be fixed,
> > > and CPAN
> > > doesn't allow uploading the same version file twice, hence the version
> > > was bumped.
> > >
> > > This release was possible due to the efforts of:
> > >
> > > Jim Winstead
> > > Tim Bunce
> > > Dave Rolsky
> > >
> > > Thanks for bug reporting from
> > >
> > > Slaven Rezic RT #25233
> > > Allard Hoeve and others alerting me to problems with version being
> > > changed from
> > > a string, which caused local issues for those who use ',' instead of '.'
> > > for decimal.
> > >
> > > And anyone else I forgot to mention. Thank you for reporting bugs and
> > > sending
> > > patches!
> > >
> > > Also, thank you for using DBD::mysql!
> > >
> > > Kind regards,
> > >
> > > Patrick Galbraith
> > >
> > > The file:
> > >
> > > file: $CPAN/authors/id/C/CA/CAPTTOFU/DBD-mysql-4.003.tar.gz
> > > size: 121582 bytes
> > > md5: 157f817d26a52aaaff61ce38f7043b95
> > >
> > >
> > --
> > Scott T. Hildreth <[EMAIL PROTECTED]>
--
Scott T. Hildreth <[EMAIL PROTECTED]>
