On Thu, 12 Apr 2007 18:02:45 -0600, tom r <[EMAIL PROTECTED]> wrote:
> Here's a patch that implements the change I spoke of on dbi-users. I'm
> submitting this for your review. It's been tested only on a Gentoo AMD64
> system.
>
> The larger problem here, is that Makefile.PL uses the last compiler option it
> finds. So if there happen to be a series of ifdef's or ifeq's then the last
> of the series will be the one whose compiler options get chosen. It would
> probably be a good idea to have Makefile.PL, when faced with choices like
> this, make an intelligent decision based upon the characteristics of the host
> compiler. How difficult could that be? ;-)
why not simply write
@@ -1135,6 +1135,8 @@
my $incompat_ext = ($MK{OBJ_EXT} && $MK{OBJ_EXT} !~ /^\./);
warn "OBJ_EXT correction enabled ($MK{OBJ_EXT})\n" if $incompat_ext;
+ # Don't include compiler options for these compilers
+ my %ignore_def = map { $_ => 1 } qw( BUILD_CCC296 BUILD_ICC );
my $mkver = 0;
my $lastline = '';
my @lines = read_inc_file($file);
As you don't use @ignore_def anywhere else
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using & porting perl 5.6.2, 5.8.x, 5.9.x on HP-UX 10.20, 11.00, 11.11,
& 11.23, SuSE 10.0 & 10.2, AIX 4.3 & 5.2, and Cygwin. http://qa.perl.org
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org
http://www.goldmark.org/jeff/stupid-disclaimers/
