On Tue, 24 Nov 2009 13:12:24 +0000, Tim Bunce <tim.bu...@pobox.com> wrote:
> > o test code using all this which demonstrates binding with a type works > > and LoosleyTyped and MinMemory do as they should. Some of this will be a > > little awkward to turn into a test that works for everyone as it needs > > Devel::Peek. Shameless plug: Data::Peek > Or JSON::XS :) Umm, or perhaps DBI::neat? Note that in our company JSON::XS is forbidden due to the appalling (read insulting) level of support (or better the lack of it) from the author. No software from Marc can be installed. So for JSON, we use JSON instead of JSON::XS. > > o I do not have a commit bit on DBD::Oracle so will pass the DBD::Oracle > > changes to John when ready. > > I'd strongly recommend John to give you a commit bit! :) :) > > Here are the changes so far: > > You've resent a diff against the original rather than a diff of your > extra changes. I can't do much with that easily. I assume the only > significant change was adding SvLEN(sv) = 0; If there's more then let me > know (as a diff of what's changed after applying my earlier diff :) > > > and DBD::Oracle (sorry about the tabbling, it seems oci.8.c has some > > very perculiar tabbling): > > [Probably tabstop=4. I used to use that before I finally realized that > tab _characters_ are at 8 column intervals and trying to pretend otherwise > caused minor but widely dispursed annoyance for myself and others. > Now my tab _key_ still indents by 4 but it uses spaces to do so. > META: This is just background info, not an invitation to anyone to open > a discussion on this topic :-] > > I've made some further changes: > > - Renamed DBIstcf_DISCARD_PV to DBIstcf_DISCARD_STRING > - DBIstcf_DISCARD_STRING only works if the cast worked ok > - No longer pass h and imp_xxh to sql_type_cast_svpv > - Added a perl API via DBI::sql_type_cast($foo, SQL_INTEGER, $flags) > - Minor return status change to indicate status of cast even if > DBIstcf_STRICT was not used. > > and committed it: > http://svn.perl.org/viewvc/modules?view=revision&revision=13591 DBI-svn > git dpull M lib/DBD/File.pm M lib/DBI/Profile.pm M Changes r13581 = 025205cb02de9e16dea21c39598704d0feec68ab (refs/remotes/git-svn) M DBI.xs M DBIXS.h M Changes M dbixs_rev.h M DBI.pm r13591 = 60aac6bc5ebf48244d7eaef61d198e62d1ed59b3 (refs/remotes/git-svn) M t/35thrclone.t r13592 = a312cfa11d5816756150f7ce04b5d1b07d709b2e (refs/remotes/git-svn) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/git-svn. DBI-svn > make test : All tests successful. Files=130, Tests=5926, 59 wallclock secs ( 1.53 usr 0.29 sys + 47.18 cusr 5.15 csys = 54.15 CPU) Result: PASS -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using & porting perl 5.6.2, 5.8.x, 5.10.x, 5.11.x on HP-UX 10.20, 11.00, 11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3. http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
