On Thu, 22 Apr 2010 10:06:04 +0100, Tim Bunce <tim.bu...@pobox.com>
wrote:
> On Wed, Apr 21, 2010 at 03:45:49PM +0100, Martin Evans wrote:
> > H.Merijn Brand wrote:
> > > This rocks!
> > >
> > > my $dbh = DBI->connect ("dbi:CSV:", undef, undef, {
> > > RaiseError => 1,
> > > PrintError => 1,
> > >
> > > f_dir => ".",
> > > f_schema => undef,
> > > f_ext => ".csv/r",
> > > f_encoding => "utf8",
> > > });
> > >
> > > Any objections to me committing that?
> >
> > Looks good to me and I'm pleased you are using encoding and not just
> > ":utf8" as the former is validating utf-8 encoding and the latter does not.
>
> Looks good to me, but...
> >
> > > + binmode $fh, ":encoding($enc)";
>
> I think requesting an invalid/unknown/broken encoding (where binmode
> returns false) should cause an error.
Is this still OK for the upcoming release, or do you want to wait?
--
H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/
using 5.00307 through 5.12 and porting perl5.13.x on HP-UX 10.20, 11.00,
11.11, 11.23, and 11.31, OpenSuSE 10.3, 11.0, and 11.1, AIX 5.2 and 5.3.
http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/
http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
