On Wed, 05 Sep 2012 11:04:23 +1000, Sven Dowideit <svendowid...@home.org.au> wrote:
> yup :) > > http://github.com/SvenDowideit/AnyData tl;dr; -- shall I take this off-list? A random number of remarks … I have a *lot* of modules - for testing - installed, but still run into new ones, and neither is mentioned when running Makefile.PL t/01distributtion.t .. skipped: Test::Distribution not installed t/01pod_snippets.t ... Can't locate Test/Pod/Snippets.pm And Test::Pod::Snippets depends on a lot of unneeded stuff like Object::InsideOut and Module::Locate, two I also had not installed. If you really want to depend on those just locally, disable these tests in the distribution if the module cannot be loaded. Even after having the modules installed, I get t/01distributtion.t .. skipped: Test::Distribution not installed t/01pod_snippets.t ... skipped: Need to do more work fixing pod code snippets so I guess it is better to just drop that test and use Test::Pod and Test::Pod::Coverage instead: t/00_pod.t ---------- #!/usr/bin/perl use strict; use warnings; use Test::More; eval "use Test::Pod 1.00"; plan skip_all => "Test::Pod 1.00 required for testing POD" if $@; all_pod_files_ok (); ---------- t/01_pod.t ---------- #!/usr/bin/perl use strict; use warnings; use Test::More; eval "use Test::Pod::Coverage tests => 1"; plan skip_all => "Test::Pod::Coverage required for testing POD Coverage" if $@; pod_coverage_ok ("AnyData", "AnyData is covered"); ---------- I miss an examples folder. Docs are fine, but examples are great Makefile.PL requires 5.004. I'd say that by now it is safe to require at least 5.6.2, but when also using DBI, require 5.8.1. Additional, you can then add: * use_warnings Add 'use warnings' to all modules. (This will require perl > 5.6) MYMETA.json/yml should include the git repo under resources Spell-checking - after filtering known words. I can give you the tools on IRC DBD-AnyData-git 529 > pod-spell-check --aspell --ispell ok 1 - AnyData.pm ok 2 - AnyData/Format/Base.pm ok 3 - AnyData/Format/CSV.pm ok 4 - AnyData/Format/FileSys.pm ok 5 - AnyData/Format/Fixed.pm ok 6 - AnyData/Format/HTMLtable.pm ok 7 - AnyData/Format/Ini.pm ok 8 - AnyData/Format/Mp3.pm ok 9 - AnyData/Format/Paragraph.pm ok 10 - AnyData/Format/Passwd.pm ok 11 - AnyData/Format/Pipe.pm ok 12 - AnyData/Format/Tab.pm ok 13 - AnyData/Format/Text.pm ok 14 - AnyData/Format/Weblog.pm ok 15 - AnyData/Format/XML.pm ok 16 - AnyData/Storage/File.pm ok 17 - AnyData/Storage/FileSys.pm ok 18 - AnyData/Storage/PassThru.pm ok 19 - AnyData/Storage/RAM.pm ok 20 - AnyData/Storage/TiedHash.pm ok 21 - sandbox/genMETA.pm 1..21 ok 1 - CommonMistakes not ok 1 - AnyData.pm # Failed test 'AnyData.pm' # at /pro/bin/pod-spell-check line 96. # got: ''additonal' => (additional additionally atonal ordinal) # 'adTie' => (ad Tie ad-Tie Addie Artie audit date adieu edit added ate artier EDT attire auntie eddied adze ante anti tattie admit Eddie Addie's Artie's) # 'containng' => (containing contain contains container contained counting contagion continuing canting condoning containers continua continue container's) # 'DTD' => (DDT TDD STD TD DD DOD DAD DID DUD DMD DTP DVD ETD LTD IT'D) # 'insdie' => (inside ins die ins-die insider onside indie insides inset Indies indies indite incite Inst inst India inside's) # 'itslef' => (itself outsell oneself Edsel Adolf outsells dissolve) # 'Malcom' => (Malcolm Talcum LCM Mailbomb Maalox Malacca Holcomb Welcome Mulct Melanoma Slocum Amalgam Locum Glaucoma Magma) # 'mltiple' => (multiple multiply multiplier multiples multiplied multiplies multiple's) # 'possiblity' => (possibility possibly possibility's possible) # 'sqaure' => (square squarer squire scare secure squared squares Sucre sure square's) # 'unpdated' => (undated updated) # 've' => (vie V v veg vet Be Ce be E e vex VA VI Va vi we VD VF VG VJ VP VT Vt vb vs DE Fe GE Ge He IE Le ME Me NE Ne OE PE Re SE Se Te Xe he me re ye Ave Eve ave eve V's I've)' # expected: '' ok 2 - AnyData/Format/Base.pm ok 3 - AnyData/Format/CSV.pm ok 4 - AnyData/Format/FileSys.pm not ok 5 - AnyData/Format/Fixed.pm # Failed test 'AnyData/Format/Fixed.pm' # at /pro/bin/pod-spell-check line 96. # got: ''formating' => (for mating for-mating formatting formation forming formulating formalin formative foaming firming fomenting formatting's floating fating format mating reformatting farming farting footing fording formfitting)' # expected: '' not ok 6 - AnyData/Format/HTMLtable.pm # Failed test 'AnyData/Format/HTMLtable.pm' # at /pro/bin/pod-spell-check line 96. # got: ''Sisk' => (Disk Sis Sask Sick Fisk Risk Silk Sink Sis's)' # expected: '' not ok 7 - AnyData/Format/Ini.pm # Failed test 'AnyData/Format/Ini.pm' # at /pro/bin/pod-spell-check line 96. # got: ''Ini' => (Uni IN In INRI Ni Ii Ina Inn Mini ING INS Inc Ind Iii Inf Ink Ins Int In's)' # expected: '' ok 8 - AnyData/Format/Mp3.pm ok 9 - AnyData/Format/Paragraph.pm ok 10 - AnyData/Format/Passwd.pm ok 11 - AnyData/Format/Pipe.pm ok 12 - AnyData/Format/Tab.pm ok 13 - AnyData/Format/Text.pm ok 14 - AnyData/Format/Weblog.pm not ok 15 - AnyData/Format/XML.pm # Failed test 'AnyData/Format/XML.pm' # at /pro/bin/pod-spell-check line 96. # got: ''DTD' => (DDT TDD STD TD DD DOD DAD DID DUD DMD DTP DVD ETD LTD IT'D) # 'formating' => (for mating for-mating formatting formation forming formulating formalin formative foaming firming fomenting formatting's floating fating format mating reformatting farming farting footing fording formfitting) # 'itslef' => (itself outsell oneself Edsel Adolf outsells dissolve)' # expected: '' ok 16 - AnyData/Storage/File.pm ok 17 - AnyData/Storage/FileSys.pm ok 18 - AnyData/Storage/PassThru.pm ok 19 - AnyData/Storage/RAM.pm ok 20 - AnyData/Storage/TiedHash.pm ok 21 - sandbox/genMETA.pm 1..21 # Looks like you failed 5 tests of 21. not ok 2 - Spell-check with aspell # Failed test 'Spell-check with aspell' # at /pro/bin/pod-spell-check line 100. ok 1 - AnyData.pm ok 2 - AnyData/Format/Base.pm ok 3 - AnyData/Format/CSV.pm ok 4 - AnyData/Format/FileSys.pm ok 5 - AnyData/Format/Fixed.pm ok 6 - AnyData/Format/HTMLtable.pm ok 7 - AnyData/Format/Ini.pm ok 8 - AnyData/Format/Mp3.pm ok 9 - AnyData/Format/Paragraph.pm ok 10 - AnyData/Format/Passwd.pm ok 11 - AnyData/Format/Pipe.pm ok 12 - AnyData/Format/Tab.pm ok 13 - AnyData/Format/Text.pm ok 14 - AnyData/Format/Weblog.pm ok 15 - AnyData/Format/XML.pm ok 16 - AnyData/Storage/File.pm ok 17 - AnyData/Storage/FileSys.pm ok 18 - AnyData/Storage/PassThru.pm ok 19 - AnyData/Storage/RAM.pm ok 20 - AnyData/Storage/TiedHash.pm ok 21 - sandbox/genMETA.pm 1..21 ok 3 - Spell-check with ispell 1..3 # Looks like you failed 1 test of 3. Not in MANIFEST: AnyData/Storage/File.pod Not in MANIFEST: t/htmltable.t Not in MANIFEST: t/xml.t * has_humanreadable_license Add a section called 'LICENSE' to the documentation, or add a file named LICENSE to the distribution. * has_test_pod_coverage Add a test using Test::Pod::Coverage to check for POD coverage. > Sven > > > On 04/09/12 21:05, H.Merijn Brand wrote: > > On Sun, 02 Sep 2012 08:56:04 +1000, Sven Dowideit<svendowid...@home.org.au> > > wrote: > >> Heya > >> > >> I used git send-emails to post some patches to rehs...@cpan.org and > >> this list, but I suspect they haven't made it due to my server setup > >> > >> before I send them again, I thought I'd test, and ask if anyone has > >> received them :) > > > > Does all of this has some git repo we could clone so we can run some > > (more) tests on it? -- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.14 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
