On Tuesday 15 May 2018 21:12:19 Tim Bunce wrote:
> On Fri, May 04, 2018 at 02:10:18PM +0200, p...@cpan.org wrote:
> > Hello, do you have any opinion or comments?
> > 
> > Tim, you as a DBI maintainer, what do you think about those ideas?
> > 
> > On Friday 27 April 2018 16:03:59 p...@cpan.org wrote:
> > > 
> > > So I'm proposing change that caller would be allowed to call
> > > $dbh->last_insert_id() without any argument
> 
> Ok.
> 
> > > Second change: Add a new statement method $sth->last_insert_id().
> 
> That seems fine. I'd write the fallback code like this:
> 
>     sub last_insert_id { return shift->{Database}->last_insert_id(@_) }

Changed.

And now I created a pull request with these changes:
https://github.com/perl5-dbi/dbi/pull/64

> Thanks Pali.
> 
> Tim.

Reply via email to