Thanks. (I'd already fixed that one, but thanks anyway.)

Tim.

On Fri, May 11, 2001 at 03:18:18PM -0700, David Dyck wrote:
> 
> 
> 
> On Fri, 30 Mar 2001, Tim Bunce wrote:
> 
> > It gives me great pleasure to announce the arrival of DBI 1.15:
> 
> When I installed this, I got the following warning during make test:
> 
> t/examp.............ok 103/122The stat preceding lstat() wasn't an lstat
> at blib/lib/DBD/ExampleP.pm line 130.
> 
> Here's a proposed patch
> 
> --- lib/DBD/ExampleP.pm.orig  Fri May 11 11:47:59 2001
> +++ lib/DBD/ExampleP.pm       Fri May 11 11:50:09 2001
> @@ -126,8 +126,8 @@
>               or return $dbh->DBI::set_err(int($!),
>                                       "Failed to open directory $dir: $!");
>           while (defined(my $file = readdir($dh))) {
> -             next unless -d $file;
> -             my($dev, $ino, $mode, $nlink, $uid) = lstat(_);
> +             my($dev, $ino, $mode, $nlink, $uid) = lstat($file);
> +             next unless -d _;
>               my $pwnam = undef; # eval { scalar(getpwnam($uid)) } || $uid;
>               push(@list, [ $dir, $pwnam, $file, 'TABLE']);
>           }
> 

Reply via email to