Thanks Jeff. Patch applied.
Tim.
On Wed, Aug 29, 2001 at 09:36:55PM -0400, Jeff Urlwin wrote:
> Tim,
>
> Fine on Win32, with the exception of the (expected) #2 below.
>
> My patch to Makefile.PL for multiple oracle homes under Win32 didn't make
> it. Attached is a diff from 1.09 for including into a later release.
>
> Still getting "FETCH" from TieRegistry upon failure. Not sure how to handle
> it, and since it's annoying, not a show-stopper, not a problem.
>
> Jeff
>
> > -----Original Message-----
> > From: Tim Bunce [mailto:[EMAIL PROTECTED]]
> > Sent: Wednesday, August 29, 2001 5:43 PM
> > To: Tim Bunce
> > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]
> > Subject: Re: ANNOUNCE: DBD::Oracle 1.09
> >
> >
> > On Wed, Aug 29, 2001 at 08:57:18PM +0100, Tim Bunce wrote:
> > > file: $CPAN/authors/id/T/TI/TIMB/DBD-Oracle-1.09.tar.gz
> > > size: 171660 bytes
> > > md5: f37850230a66b7a0b3240b9667fbf812
> >
> > FYI, some minor issues have come to light already:
> >
> > 1/ This release needs DBI 1.20 in order to pass the tests.
> >
> > 2/ The t/ph_type test generates a spurious warning about
> > a table not existing. The warning can be ignored.
> >
> > Tim.
> >
> *** Makefile.PL.orig Wed Aug 29 21:24:36 2001
> --- Makefile.PL Wed Aug 29 21:28:37 2001
> ***************
> *** 627,634 ****
> if ($oh1 = &$Val($hkey)) && -d $oh1;
> push @hkey, &$Keys($hkey);
> }
> ! print "\nMultiple Oracle homes: ", join(" ", sort keys %oh), "\n\n"
> ! if 1 < keys %oh;
> } if defined $Keys;
> }
>
> --- 627,649 ----
> if ($oh1 = &$Val($hkey)) && -d $oh1;
> push @hkey, &$Keys($hkey);
> }
> ! if (1 < keys %oh) {
> ! # JLU: 8/21/01 Oracle's default home is the first one in
> ! # the path, at least with 8i
> ! print "\n\007Multiple Oracle homes: ", join(" ", sort keys %oh), "\n\n";
> ! my @path = split(";", $ENV{PATH});
> ! my $dir;
> ! foreach $dir (@path) {
> ! # the path will be c:\path\to\home\bin, so remove \bin
> ! # if it's there.
> ! $dir =~ s/\\bin$//;
> ! if (defined($oh{$dir})) {
> ! print "$dir is first in the PATH, and is the Oracle's default
>home.\n\n";
> ! $oh = $dir;
> ! last;
> ! }
> ! }
> ! }
> } if defined $Keys;
> }
>
