Patrick Galbraith wrote: >Steve, > >Thank you so much for these patches! I love open source! > >I'm sorry about forgetting about the removal of strcasencmp - this was >something I had planned to do, and even Monty said to change it. About >'my_global.h' and longlong - I wanted to use this, especially for the >'rows' issue, but had all sorts of warnings and errors upon adding it >to dbdimp.h, which seemed to do with issues between perl API and mysql >API. Did you not have these issues? > > Yes - as I said, there were a bunch of warnings about macro redefinitions, but no errors. Here's the warnings that I get (using perl 5.8.6 and mysql 4.1.9):
C:\mysql\include\config-win.h(70) : warning C4005: 'S_IROTH' : macro redefinition C:\perl5\lib\CORE\perl.h(1003) : see previous definition of 'S_IROTH' C:\mysql\include\config-win.h(118) : warning C4005: 'bool' : macro redefinition C:\perl5\lib\CORE\handy.h(85) : see previous definition of 'bool' C:\mysql\include\config-win.h(129) : warning C4005: 'isnan' : macro redefinition C:\perl5\lib\CORE\win32.h(211) : see previous definition of 'isnan' C:\mysql\include\config-win.h(174) : warning C4005: 'sleep' : macro redefinition C:\perl5\lib\CORE\win32iop.h(294) : see previous definition of 'sleep' C:\mysql\include\config-win.h(179) : warning C4005: 'access' : macro redefinition C:\perl5\lib\CORE\win32iop.h(277) : see previous definition of 'access' C:\mysql\include\config-win.h(209) : warning C4005: 'lseek' : macro redefinition C:\perl5\lib\CORE\win32iop.h(242) : see previous definition of 'lseek' C:\mysql\include\config-win.h(210) : warning C4005: 'tell' : macro redefinition C:\perl5\lib\CORE\win32iop.h(243) : see previous definition of 'tell' Clearly these need ironing out, but they're better than errors about Win32 missing "long long". >Again, thanks so much for your work on this. I do intend to start >poking at testing this on windows, and will probably be asking you >questions as I do! > I'm happy to assist in any way I can. Btw, did you miss or deliberately duck the charset/UTF-8 question? Cheers, - Steve ------------------------------------------------ Radan Computational Ltd. The information contained in this message and any files transmitted with it are confidential and intended for the addressee(s) only. If you have received this message in error or there are any problems, please notify the sender immediately. The unauthorized use, disclosure, copying or alteration of this message is strictly forbidden. Note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of Radan Computational Ltd. The recipient(s) of this message should check it and any attached files for viruses: Radan Computational will accept no liability for any damage caused by any virus transmitted by this email.