Thanks Aran. After looking at the code here are my questions/comments: - The module requires a "position" column in the underlying table to maintain some notion of order. How common is this practice? I've never done it, but that doesn't mean anything.
- How well will the module play with auto-increment columns? I see the insert and delete methods expect to be able to update the position column at will, so you probably wouldn't want to use an auto-increment column for your position. Maybe a note in the doc? - What's a typical use case for this? Since every move_* method results in a call to the database, you wouldn't want to use it for rapid traversal of a table. When would you use it? I'm not convinced it belongs in the main distribution. - Alan -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Aran Deltac Sent: Monday, April 03, 2006 9:14 AM To: [email protected] Subject: Re: [Dbix-class] RFC: DBIx-Class-Tree Alan, There is this fuzzy dividing line between what should and should not be included in the core DBIC distro. The general idea is that anything that does not add external dependencies, and is a common paradigm that people deal with on a regular basis, then it is a potential candidate for inclusion. Ordered was deamed worthy, and thus included. The docs can be easly read by perldoc'ing the source at: http://dev.catalyst.perl.org/repos/bast/branches/DBIx-Class-current/lib/DBIx /Class/Ordered.pm Aran On 4/3/2006, "Alan Humphrey" <[EMAIL PROTECTED]> wrote: > > >> Oh, and I'd like to add that the first release of this will depend on >> DBIx::Class 0.07000 shipping, so it will most likely be a bit longer >> than a week! This is because DBIC:Tree::AdjecencyList::Ordered depends >> on the new DBIC:Ordered module, which is not in 0.06000, but has been in >> the DBIC subversion repo for a while. > >If nobody's massively offended by the idea I think I'd like to roll the >::Ordered component into 0.06001 along with the SQLT deploy improvements in >-current. > >What do people think of this idea? > >-- > >I have no opinion about the module since I don't know what it does. What is >::Ordered and why should it be part of the core distribution? > >I'm not trying to be snarky, just trying to get a handle on what's going on. > >- Alan > > >_______________________________________________ >List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class >Wiki: http://dbix-class.shadowcatsystems.co.uk/ >IRC: irc.perl.org#dbix-class >SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/ _______________________________________________ List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class Wiki: http://dbix-class.shadowcatsystems.co.uk/ IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/ _______________________________________________ List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class Wiki: http://dbix-class.shadowcatsystems.co.uk/ IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
