On 7/18/06, Matt S Trout <[EMAIL PROTECTED]> wrote:
> Brandon Black wrote:
> > On 7/18/06, Nilson Santos Figueiredo Junior <[EMAIL PROTECTED]> wrote:
> >> Attached you'll find a patch which changes dump_overwrite behaviour so
> >> that when it's false (i.e. it shouldn't overwrite files), instead
> >> throwing an exception when an already existing file is found, it
> >> merely warns and skips it.
> >>
> >> This is rather useful when you're e.g. adding new tables to an
> >> existing Catalyst application and want to use the Helper with
> >> "create=static" for code generation.
> >>
> >> The patch fixes one test case so that it complies with this new
> >> behaviour (thus, Test::Warn was added as a build dependency). It also
> >> changes two or three words on the docs reflecting the change.
> >>
> >
> > Thanks. Its applied and should show up in the 0.03005 release.
>
> If local $SIG{WARN} would be sufficient to the test please don't add another
> dependency just to get syntactic sugar in code most users will never see.
>
You're right of course, I guess it was too early in the morning for me
to think that clearly, the test has been amended now.
-- Brandon
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/[email protected]/
