Matija Grabnar wrote:
> Brandon Black wrote:
>> On 7/16/06, Matija Grabnar <[EMAIL PROTECTED]> wrote:
>>
>>> Matt S Trout wrote:
>>>
>>>> This is the only functional change since 06999_07 so provided that's ok I
>>>> reckon we're ready to ship 07 (you *did* all test 06999_07, right?
>>>>
>>> I tested it with an application I wrote which has a fair number of joins
>>> and some prefetches, but none really tricky. It seems to work OK.
>>>
>>> However, when I tried DBIx::Class:Schema::Loader 0.3004, I noticed a
>>> bug. Given a field like
>>>
>>> `bulk_euro_notax` decimal(11,2) NOT NULL,
>>>
>>> schema::loader generates
>>>
>>> "bulk_euro_notax",
>>> { data_type => "DECIMAL", default_value => "", is_nullable => 0, size
>>> => 11 },
>>>
>>> In other words, it loses the ",2" in the size of the decimal. That
>>> decimal is very important when working with monetary values.
>>>
>>>
>> I'll take a look at this in the next few days if nobody else does.
>> The Loader gets it from Storage::DBI's columns_info_for, which in turn
>> gets it from DBI, the issue could be in either of those, or possibly a
>> DBD deficiency.
>>
>> -- Brandon
>>
> Um, has anything been done about this yet?
Um, have you made any attempt to track down which of these possible causes is
at fault? So far I don't even see a report of which database is involved, and
most of us use Schema::Loader as a quickstart only; relying on such a system
in production is generally considered dangerous.
Does columns_info_for report this correctly? Does your DBD report it
correctly? Do earlier versions of Schema::Loader do the right thing?
C'mon dude, you're the only one who's reported this so far. Give us a hand :)
--
Matt S Trout Offering custom development, consultancy and support
Technical Director contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd. mst (at) shadowcatsystems.co.uk for more information
+ Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/[email protected]/
