Ok i will. as soon as i find some time.
2007/6/6, Tim Bunce <[EMAIL PROTECTED]>:
I found some time to look at it today.
Two bugs caught my eye:
* the is_disconnect_*() methods clobber $_, use local()
* reconnect() clobbers $SIG{ALRM}, use local()
I've a list of other issues that I don't have time to transcribe and
explain. Sorry.
Much of the code could be simplified by tighter integration with DBI
features. Could possibly be reduced to less than half the size.
If you write a comprehensive test suite[*] for it and comment the code
more I'd be willing work on the code directly.
Tim.
[*] See http://search.cpan.org/~timb/DBI/lib/DBI/Gofer/Execute.pm#TESTING
for a way to simplify testing failure handling.
On Tue, May 29, 2007 at 02:46:17PM +0400, Oleg Pronin wrote:
> And?
>
> 2007/5/13, Brandon Black <[EMAIL PROTECTED]>:
>
> On 5/12/07, Oleg Pronin <[EMAIL PROTECTED]> wrote:
> > So ? Did you see it?
> >
>
> I haven't had time to look at it yet, but I will soon :)
>
> -- Brandon
>
> _______________________________________________
> List:
[3]http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
> Wiki: [4]http://dbix-class.shadowcatsystems.co.uk/
> IRC: irc.perl.org#dbix-class
> SVN: [5]http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
> Searchable Archive: [6]http://www.mail-
archive.com/[email protected]/
>
> References
>
> Visible links
> 1. mailto:[EMAIL PROTECTED]
> 2. mailto:[EMAIL PROTECTED]
> 3. http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
> 4. http://dbix-class.shadowcatsystems.co.uk/
> 5. http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
> 6. http://www.mail-archive.com/[email protected]/
> _______________________________________________
> List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
> Wiki: http://dbix-class.shadowcatsystems.co.uk/
> IRC: irc.perl.org#dbix-class
> SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
> Searchable Archive:
http://www.mail-archive.com/[email protected]/
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive:
http://www.mail-archive.com/[email protected]/
_______________________________________________
List: http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
Wiki: http://dbix-class.shadowcatsystems.co.uk/
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
Searchable Archive: http://www.mail-archive.com/[email protected]/
