Moritz Onken wrote:
> After talking to mst, the exception was degraded to a warn.
> Patch attached.
> 

Why lose the verbosity of the warning? How about:

carp (
    "Prefetching multiple has_many rels ${last} and ${pre} "
    .(length($as_prefix)
        ? "at the same level (${as_prefix}) "
        : "at top level "
    )
    . 'will currently disrupt both the functionality of $rs->count(), '
    . 'and the amount of objects retrievable via $rs->next(). '
    . 'Use at your own risk.'
);


Also don't blindly disable tests, but instead adjust them to test if the
proper warning is emitted.

_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk

Reply via email to