On Wed, 5 Nov 2008 14:58:12 +0100 "Zbigniew Lukasiak" <[EMAIL PROTECTED]>
wrote:
> I've started testing it with the latest DBIC.
Hi,
since we have other volunteers now, I'll start to send my patches here to
avoid debugging and fixing the same bugs again that I've already found and
fixed (or at least created patch for). (My original plan was to collect
them in a branch, but I don't have commit access (yet?).)
Here goes the first:
In DBIC t/96_is_deteministic_value.t dies, the attached SQLA patch fixes
it (TC included).
norbi
Index: t/06order_by.t
===================================================================
--- t/06order_by.t (revision 5055)
+++ t/06order_by.t (working copy)
@@ -44,6 +44,11 @@
expects => ' ORDER BY colA, colB DESC',
expects_quoted => ' ORDER BY `colA`, `colB` DESC',
},
+ {
+ given => undef,
+ expects => '',
+ expects_quoted => '',
+ },
);
my $sql = SQL::Abstract->new;
Index: lib/SQL/Abstract.pm
===================================================================
--- lib/SQL/Abstract.pm (revision 5055)
+++ lib/SQL/Abstract.pm (working copy)
@@ -711,6 +711,7 @@
},
SCALAR => sub {$self->_quote($arg)},
+ UNDEF => sub {},
SCALARREF => sub {$$arg}, # literal SQL, no quoting
HASHREF => sub {$self->_order_by_hash($arg)},
_______________________________________________
List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
IRC: irc.perl.org#dbix-class
SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
