Hi Peter, On Mon, Jan 11, 2010 at 10:24 AM, Peter Rabbitson <rabbit+d...@rabbit.us> wrote: > Hi, nice work. There is a slight problem with how you are treating a > single scalar. In SQLA the general prinicple is that if you want to > pass random strings, you pass \'...stuff...' (scalarref). Anything > else is subject to quoting (which you do not test). So for example > I would expect returning => 'id, foo, bar' } to generate > ... RETURNING "id, foo, bar" > when quoting is engaged. Please augment the tests and introduce > scalarref handling (scalar should be treated as 1-element arrayref) > > Also if you prefer to work on a branch I or mst can set you up with > a commit bit to the repo. Drop either one of us a line in #dbix-class
Thanks for the feedback, I've included a patch which I think addresses
these problems.
No need for a branch, this is only small stuff :)
--
Oliver Charles / aCiD2
insert-returning.patch
Description: Binary data
_______________________________________________ List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
