Just tried this for myself. A lot of warnings..
I guess the cleaned up statements are in the patches you'll send me
today? ;)
I agree we should keep the __attribute__ thing in the source. It does
not cost us anything, and it helps preventing bugs. Sounds like free
lunch to me! :)
Ilja
Aaron Stone wrote:
Well that was fun! I also caught three or four more of the missing comma
errors, and a handful of "%s, %s: ...." formats that were missing the
__FILE__, __FUNCTION arguments.
I cleaned up all of the warnings, though we should definitely keep the GNU
attribute in the source to warn against format bugs in the future.
Aaron
"Aaron Stone" <[EMAIL PROTECTED]> said:
I found the GNU extension to turn on pritnf style format checking! In debug.h,
make this your declaration of trace():
void trace(int level, char *formatstring, ...)
__attribute__((format(printf, 2, 3)));
Voila, tons of errors next time you make.
Aaron
