Hi
Paul J Stevens wrote:
Hi all,
Since there were no takers, I did a follow-up on my earlier conclusion
that the networking code could do with some improvements.
For those of you who haven't followed the list; dbmail2 won't work with
mozilla and derivatives.
Well, it does work here, but only after applying some changes in the ACL
commands (which I did last Friday). By the way, I've used Mozilla
Thunderbird 0.5, and Mozilla Mail from the Mozilla 1.5 suite.
I've wrapped the code talking to clients in simple wrappers with error
checking, and lo; mozilla suddenly works just fine with dbmail2 :-)
Was that before or after using the renewed ACL code I added?
As a proof-of-concept I'm attaching my patch against the HEAD branch as
of today.
This is not for inclusion in CVS just yet. It's still kind of rough, but
I wanted to share my relief that this really does appear to fix the bug.
Also, pop3.c and lmtpd.c would probably also benefit from this approach
as well.
I like the way your code works. This is definitly something we can use
for our other daemons.
IMO imap4.c and friends could do with some re-indenting. Looks like
there are several different indent-styles intertwined in the code. Any
consensus on that regard ?
Yep. I'd like to run indent -kr on those files. It's my wrong the
indenting is screwed up by the way.
Ilja
