Aaron Stone wrote:
You're kidding me.
I'm not..

I've spent the last several months working with the understanding that all
lines should end with \r\n, and lines that don't end in \r\n need to be
treated carefully to avoid breaking things.

I was assuming the same thing. However, the problem with viewing the messages in Outlook (headers showing in message body), eventually led me to find that we were sending \r\r\n as line ending to the client when \r\n was the end-of-line in the db.

First I tried fixing it by fixing message output to the client, but there's some proper magic going on in mime.c, that I wanted to avoid breaking..

The easy solution was to always get \n as lending into the db..

The important thing for me was to get this working. We'll deal with all the magic in mime.c later on.

Ilja


*sigh*

Aaron


Ilja Booij <[EMAIL PROTECTED]> said:


Aaron,

Aaron Stone wrote:


Why are there only \n's between header lines? None of the code that I've run
on my system, in any combination of LMTP and SMTP, produces header lines
without carriage returns (as \r\n pairs). I'm *very* confused...

Are you running a snapshot with Ilja's latest header/body code?

Does this message parse correctly in Outlook?

The missing '\r's is because of my recent changes: In DBMail 1.x, dbmail-smtp inserted without '\r'. A lot of code in mime.c is quite dependent on reading the messages from the database without the carriage returns. This is wrong, but the code is not easily changeable (it should be refactored..). My recent changes make sure messages inserted with LMTP are stripped of the '\r' so all other functions still work.

Messages with \r\n as line ending were not correctly parsed in Outlook, because *somewhere* in the code, \r\n was changed to \r\r\n.

I hope this explains it :)

Ilja

_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://twister.fastxs.net/mailman/listinfo/dbmail-dev





Reply via email to