Dan Weber wrote:
Ilja Booij wrote:
Dan Weber wrote:
I guess thunderbird doesn't like copy and paste.
2004-07-01 Dan Weber <[EMAIL PROTECTED]>
* auth/authsql.c, db.c: replaced function definitions with 0
arguments with a void argument.
Is this necessary or just good practice? If so, we can apply this
later on.
Necessary. The C compiler doesn't do type checking so you should fill
an empty argumented function with void. Otherwise they can just pass
unlimited arguments to the function.
We'll fix this later on then (after release of 2.0)
* db.h, mysql/dbmysql.c, pgsql/dbpgsql.c (db_num_rows):
changed
type cast from unsigned to long long as suggested by Intel
Compiler.
Why should this be a long long? I can't see the reason for it. What's
the output from the Intel compiler?
The Intel Compiler claimed that res was a long long and was being
converted to an unsigned on return. It said you were probably losing
bytes.
ok, after looking it up: mysql_num_rows() returns unsigned long long.
PQntuples() returns int. We should return unsigned long long. We should
also check if PQntuples() > 0 and cast that to an unsigned long long.
This is something that can wait though.
* None: Made compatibility for more compilers, most notably
tcc
and icc.
Which changes do that?
Above changes. ICC is much stricter and has a much better lint than
gcc, its worth a try. For non-commercial its free as in beer.
Sounds good
Ilja
--
Ilja Booij
IC&S B.V.
Stadhouderslaan 57
3583 JD Utrecht
www.ic-s.nl
T algemeen: 030 6355730
T direct: 030 6355739
F: 030 6355731
E: [EMAIL PROTECTED]
