On Aug 3, 2004, at 9:20 AM, Dan Weber wrote:

There are some major problems with pgsql at the moment. I couldn't tell you if it was the dbmail driver, or pgsql itself, but I know that it keeps eating disk space like crazy. Sometimes vacuuming it helps, but not really. I think we should have a full review of the dbpgsql driver.

I've been testing with pgsql and not run into this problem. It's possible that I just haven't hit whatever operation it is that causes this.

 long long db_num_rows(void)
+// This typecase is evil.  Its not always true
+// if this function returns 0
 {

Not sure what you mean here. At the very least db_num_rows() type must be consistent across drivers. Is u64_t a better choice for portability?

+// inline will be better because I can't see why wasting a function call is a
+// good idea.  As well, the type checking stays.


inline is not portable, doesn't work properly with all versions of gcc, and is done automatically by -O3. no need to add this.

Reply via email to