The following bug has been CLOSED ====================================================================== http://www.dbmail.org/mantis/bug_view_advanced_page.php?bug_id=0000090 ====================================================================== Reported By: paul Assigned To: ilja ====================================================================== Project: DBMail Bug ID: 90 Category: Command-Line programs (dbmail-users, dbmail-util) Reproducibility: always Severity: major Priority: normal Status: closed ====================================================================== Date Submitted: 15-Sep-04 12:45 CEST Last Modified: 13-Oct-04 10:41 CEST ====================================================================== Summary: -n switch is non-functional for dbmail-util Description: Despite using -n actions are still performed. ======================================================================
---------------------------------------------------------------------- ilja - 15-Sep-04 15:37 CEST ---------------------------------------------------------------------- The same seems to be the fact for dbmail-users. Aaron, is this intented, is it a slip? Should we perhaps just remove the documentation for the '-n' option? (from man-pages and on-line help) ---------------------------------------------------------------------- aaron - 15-Sep-04 17:04 CEST ---------------------------------------------------------------------- Gaa, there I go again. I remember looking at the queries involved in database cleanup and not figuring out how I was going to implement proper output for, say, 'dbmail-util -nv -cturpd' where it should tell you all about what it wants to fix but not actually fix anything... and then moving onto other parts of the project and not getting back to those queries :-\ I suppose we should pull -n for now, unless there's some trivially simple logic to prevent actions from being taken that I didn't see the first time around. I would suggest using the same type of error message as is currently being used for '-i' interactive option (which may never be implemented, but I thought it would be appropriate to reserve the option letter in all of the binaries). ---------------------------------------------------------------------- ilja - 15-Sep-04 17:16 CEST ---------------------------------------------------------------------- So, what would be the best way to pull this out? * remove from accepted switches in getopt() call. * remove from help output * remove from man page is that all? ---------------------------------------------------------------------- aaron - 15-Sep-04 17:29 CEST ---------------------------------------------------------------------- I'd rather leave it in getopt but add a warning like -i has. We could remove it from help and man pages... I'd like to implement the functionality in a point release, so we'd just remove the warning and let it begin working. ---------------------------------------------------------------------- ilja - 16-Sep-04 16:10 CEST ---------------------------------------------------------------------- I've done the following for dbmail-users and dbmail-util in dbmail_2_0_branch: -n & -y options only display a message that they are not supported in this version. -h does not display those options. They've also been commented out in the manpages. ---------------------------------------------------------------------- ilja - 16-Sep-04 16:48 CEST ---------------------------------------------------------------------- * -n and -y switches have been commented out in manpages. * -h does not show these switches anymore * when choosen, a message is displayed that those options do no work for this release and program is stopped. The points above go for dbmail-util and dbmail-users, in both HEAD and dbmail_2_0_branch Bug History Date Modified Username Field Change ====================================================================== 15-Sep-04 12:45paul New Bug 15-Sep-04 15:37ilja Bugnote Added: 0000247 15-Sep-04 15:39ilja Status new => confirmed 15-Sep-04 17:04aaron Bugnote Added: 0000250 15-Sep-04 17:16ilja Bugnote Added: 0000251 15-Sep-04 17:29aaron Bugnote Added: 0000254 16-Sep-04 16:10ilja Bugnote Added: 0000268 16-Sep-04 16:46ilja Assigned To => ilja 16-Sep-04 16:46ilja Status confirmed => assigned 16-Sep-04 16:48ilja Bugnote Added: 0000269 16-Sep-04 16:48ilja Resolution open => fixed 16-Sep-04 16:48ilja Status assigned => resolved 13-Oct-04 10:41ilja Status resolved => closed ======================================================================