A BUGNOTE has been added to this bug.
======================================================================
http://www.dbmail.org/mantis/bug_view_advanced_page.php?bug_id=0000103
======================================================================
Reported By: blake
Assigned To: aaron
======================================================================
Project: DBMail
Bug ID: 103
Category: Command-Line programs (dbmail-users, dbmail-util)
Reproducibility: always
Severity: minor
Priority: normal
Status: feedback
======================================================================
Date Submitted: 15-Oct-04 09:18 CEST
Last Modified: 30-Nov-04 03:00 CET
======================================================================
Summary: dbmail-util -q isn't quiet
Description:
running dbmail-util with the -q option has no effect
======================================================================
----------------------------------------------------------------------
aaron - 15-Oct-04 18:16 CEST
----------------------------------------------------------------------
Quite right. Most of the printf's were not changed over to the quiet printf
macro.
----------------------------------------------------------------------
blake - 19-Oct-04 01:47 CEST
----------------------------------------------------------------------
Here's a diff vs: 2.0.0 that appears to fix evertything for me. Aaron, you
may want to look this over before commiting it. All my comments begin with
"BAM" and I put one everywhere I had a question.
----------------------------------------------------------------------
aaron - 31-Oct-04 12:36 CET
----------------------------------------------------------------------
This patch is spot-on. The stderr stuff I just put into the ordinary
qprintf() because it's nothing too special. Nice work! Sorry it took me so
long to get to it :-[
----------------------------------------------------------------------
blake - 30-Nov-04 00:59 CET
----------------------------------------------------------------------
Thanks for fixing this Aaron, unfortunately one bad line crept into 2.0.1:
--- maintenance.c.orig Mon Nov 29 18:51:18 2004
+++ maintenance.c Mon Nov 29 18:55:17 2004
@@ -373,8 +373,11 @@
return -1;
}
- qerrorf("Ok. Found [%ld] physmessages without messageblocks.\n",
- lostlist.total_nodes);
+ if (lostlist.total_nodes > 0)
+ qerrorf("Ok. Found [%ld] physmessages without
messageblocks.\n",
+ lostlist.total_nodes);
+ else
+ qprintf("Ok. Found no physmessages without
messageblocks.\n");
if (lostlist.total_nodes > 0) {
el = lostlist.start;
----------------------------------------------------------------------
aaron - 30-Nov-04 03:00 CET
----------------------------------------------------------------------
Basically you want absolutely no output from dbmail-util -q unless
something really is wrong. Is this the only message that made it through?
Bug History
Date Modified Username Field Change
======================================================================
15-Oct-04 09:18blake New Bug
15-Oct-04 18:16aaron Assigned To => aaron
15-Oct-04 18:16aaron Status new => assigned
15-Oct-04 18:16aaron Bugnote Added: 0000313
19-Oct-04 01:47blake File Added: maintenance.diff
19-Oct-04 01:47blake Bugnote Added: 0000316
31-Oct-04 12:36aaron Bugnote Added: 0000326
31-Oct-04 12:36aaron Resolution open => fixed
31-Oct-04 12:36aaron Status assigned => resolved
30-Nov-04 00:59blake Bugnote Added: 0000389
30-Nov-04 00:59blake Resolution fixed => reopened
30-Nov-04 00:59blake Status resolved => feedback
30-Nov-04 03:00aaron Bugnote Added: 0000390
======================================================================
