On Sat, Jul 16, 2005, ""Christian G. Warden"" <[EMAIL PROTECTED]> said:
> On Sat, Jul 16, 2005 at 05:38:34PM -0400, M. J. [Mike] O'Brien wrote: >> Suggestion: >> 1) Use DbMail 2.0.4 stable > > I'm using 2.1 mainly for the table prefix. I'm upgrading an old pre 2.0 > installation, before the dbmail_ prefix was added to the tables. I have > a lot of code that interacts with the dbmail tables so I don't want to > rename the tables right now. > > Unfortunately, it looks like the table prefix code is somewhat broken. I'm looking at it right now; this bit of code needs a rewrite. > config.c always sets the table prefix to DEFAULT_DBPFX. Also, the > iniparser treats and empty right-hand-side the same as if the key > doesn't exist so there doesn't appear to be a way to set the prefix to > an empty string. Have you tried quoting? e.g. table_prefix = "" > I think I'll probably just have to change > DEFAULT_DBPFX. And finally, there are a handful of places in db.c where > the dbmail_ prefix is hard-coded into the queries, but these are easy to > fix. Send patches! >> 2) Or ... you can install check ( http://check.sourceforge.net/ ) >> or unless you really want to run all the tests, remove the reference. > > There is a 'check' Debian package. The Build-Depends in the control > file simply needs to be updated. We'd be better off allowing Check to be disabled in the configure script. Aaron
