Aaron Stone wrote: > On Mon, Apr 17, 2006, Paul J Stevens <[EMAIL PROTECTED]> said: > > >>[EMAIL PROTECTED] wrote: >> >>>---------------------------------------------------------------------- >>> aaron - 17-Apr-06 21:43 >>>---------------------------------------------------------------------- >>>I have a fix for this in my tree, but I haven't fully tested it yet. >> >>Great Aaron, then I can sit back on this one. It seems to me this whole >>pipe interface should be refactored into a single entrypoint. int static >>send_mail in pipe.c looks like a recent addition and a prime candidate. > > > It made a bit of a mess when I rolled the work of forward.c into pipe.c, > because forward is able to use applications other than sendmail, but the > good news is that there's now exactly one call to popen in the entire > codebase. > > >>Perhaps reworking it into an api addition like >> >>int dbmail_message_sent(struct DbmailMessage *m, const char *from, const >>char *to); >> >>is in order here. > > > There's a family of functions in pipe.c, most of which are static, but > they could definitely become API... > > Should I create a new file, dbmail-send[mail?].c, and put them in there?
Why? Most are wrappers for send_mail which is already setup to become a method for dbmail-message.c. -- ________________________________________________________________ Paul Stevens paul at nfg.nl NET FACILITIES GROUP GPG/PGP: 1024D/11F8CD31 The Netherlands________________________________http://www.nfg.nl
