The following issue has been RESOLVED.
======================================================================
http://www.dbmail.org/mantis/view.php?id=324
======================================================================
Reported By: kaname
Assigned To: aaron
======================================================================
Project: DBMail
Issue ID: 324
Category: Database layer
Reproducibility: always
Severity: minor
Priority: normal
Status: resolved
Resolution: fixed
Fixed in Version: SVN Trunk
======================================================================
Date Submitted: 17-Apr-06 16:33 CEST
Last Modified: 29-Apr-06 04:06 CEST
======================================================================
Summary: The result value from DB is not cleared
Description:
In db_calculate_quotum_all() of db.c,
the result value from DB is not cleared.
In _header_get_id() of dbmail-message.c,
the result value from DB is not cleared.
Please take it though it is an easy patch.
======================================================================
----------------------------------------------------------------------
paul - 18-Apr-06 14:53
----------------------------------------------------------------------
patch applied.
----------------------------------------------------------------------
kaname - 26-Apr-06 14:13
----------------------------------------------------------------------
There is one place where db_free_result() is not executed.
--- db.c~ 2006-04-26 18:39:38.000000000 +0900
+++ db.c 2006-04-26 21:02:06.753657260 +0900
@@ -391,20 +391,21 @@
if (n == 0) {
trace(TRACE_DEBUG, "%s,%s: quotum is already up to date",
__FILE__, __func__);
db_free_result();
return DM_SUCCESS;
}
if (!(user_idnrs = (u64_t *) dm_malloc(n * sizeof(u64_t)))) {
trace(TRACE_ERROR, "%s,%s: malloc failed. Probably out of
memory..",
__FILE__, __func__);
+ db_free_result();
return -2;
}
if (!(curmail_sizes = (u64_t *) dm_malloc(n * sizeof(u64_t)))) {
trace(TRACE_ERROR, "%s,%s: malloc failed: Probably out of
memort..",
__FILE__, __func__);
dm_free(user_idnrs);
db_free_result();
return -2;
}
memset(user_idnrs, 0, n * sizeof(u64_t));
----------------------------------------------------------------------
aaron - 29-Apr-06 04:06
----------------------------------------------------------------------
One liner committed.
Issue History
Date Modified Username Field Change
======================================================================
17-Apr-06 16:33 kaname New Issue
17-Apr-06 16:33 kaname File Added: dbmail-free_result2.patch
18-Apr-06 14:53 paul Note Added: 0001089
18-Apr-06 14:53 paul Status new => resolved
18-Apr-06 14:53 paul Resolution open => fixed
18-Apr-06 14:53 paul Fixed in Version => SVN Trunk
26-Apr-06 14:13 kaname Status resolved => feedback
26-Apr-06 14:13 kaname Resolution fixed => reopened
26-Apr-06 14:13 kaname Note Added: 0001108
29-Apr-06 04:06 aaron Status feedback => resolved
29-Apr-06 04:06 aaron Resolution reopened => fixed
29-Apr-06 04:06 aaron Assigned To => aaron
29-Apr-06 04:06 aaron Note Added: 0001117
======================================================================
