ok.
Leif Jackson wrote:
> can you please also get the row is NULL above the result is NULL I missed
> that in my patch.
>
> Thanks,
> Leif
>
>
> On Tue, September 19, 2006 9:23 am, Paul J Stevens wrote:
>> fix applied (to dbpgsql.c as well).
>>
>> thanks,
>>
>> Leif Jackson wrote:
>>
>>> Paul,
>>>
>>>
>>> even though these warning are harmless they should be fixed, this is
>>> minor yes but still will save you and aaron and the list time not
>>> answering this question again so I belive this is the best fix:
>>>
>>>
>>> diff -urNb dbmail-svn-2.1.8-2270.orig/modules/dbmysql.c
>>> dbmail-svn-2.1.8-2270/modules/dbmysql.c ---
>>> dbmail-svn-2.1.8-2270.orig/modules/dbmysql.c 2006-09-18
>>> 14:27:31.000000000 -0400
>>> +++ dbmail-svn-2.1.8-2270/modules/dbmysql.c 2006-09-19
>>> 07:17:57.000000000 -0400
>>> @@ -236,7 +236,7 @@
>>> return NULL; }
>>>
>>>
>>> - if ((row >= db_num_rows()) || (field >= db_num_fields())) {
>>> + if ((row > db_num_rows()) || (field > db_num_fields())) {
>>> trace(TRACE_WARNING, "%s, %s: " "row = %u, field = %u, bigger than size
>>> of result set", __FILE__, __func__, row, field);
>>> @@ -266,7 +266,7 @@
>>>
>>>
>>> result = last_row[field]; if (result == NULL) -
>>> trace(TRACE_WARNING, "%s,%s: result is null\n", +
>>> trace(TRACE_DEBUG, "%s,%s: result is null\n", __FILE__, __func__);
>>> return result; }
>>>
>>>
>>>
>>> the first diff is because you get a erounous bigger than size of result
>>> set for row == 0 and field == 0 which is not what I belive that
>>> warning was ment for. and the second addresses report 405 and just makes
>>> it a debuging message only if you and aaron don't want to remove that
>>> completly.
>>>
>>>
>>> as always just my 0.02 :)
>>>
>>> Thanks,
>>> Leif
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Dbmail-dev mailing list
>>> Dbmail-dev@dbmail.org
>>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>>>
>>>
>> --
>> ________________________________________________________________
>> Paul Stevens paul at nfg.nl
>> NET FACILITIES GROUP GPG/PGP: 1024D/11F8CD31
>> The Netherlands________________________________http://www.nfg.nl
>> _______________________________________________
>> Dbmail-dev mailing list
>> Dbmail-dev@dbmail.org
>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>>
>>
>
>
> _______________________________________________
> Dbmail-dev mailing list
> Dbmail-dev@dbmail.org
> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
>
--
________________________________________________________________
Paul Stevens paul at nfg.nl
NET FACILITIES GROUP GPG/PGP: 1024D/11F8CD31
The Netherlands________________________________http://www.nfg.nl
