The following issue has been REOPENED. 
====================================================================== 
http://dbmail.org/mantis/view.php?id=543 
====================================================================== 
Reported By:                menole
Assigned To:                paul
====================================================================== 
Project:                    DBMail
Issue ID:                   543
Category:                   POP3 daemon
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
target:                      
====================================================================== 
Date Submitted:             19-Mar-07 14:16 CET
Last Modified:              24-Mar-07 20:15 CET
====================================================================== 
Summary:                    Logging does not say anything about the remote users
ip
Description: 
Failed pop3 login attempts are logged as follows:
Mar 19 13:10:47 dbmail-01 dbmail/pop3d[25510]: Error user [bla] tried to
login with wrong password

Nice to know that there was a failed attempt, but no idea how to handle.
Please add user's IP into log message:
Mar 19 13:55:36 dbmail-01 dbmail/pop3d[30326]: Error user [bla] comming
from [192.168.3.140] tried to login with wrong password

patch for pop3.c is attached

Kind Regards,

Michael Mende
====================================================================== 

---------------------------------------------------------------------- 
 paul - 23-Mar-07 13:54  
---------------------------------------------------------------------- 
Fixed in rev 2474 

---------------------------------------------------------------------- 
 menole - 24-Mar-07 20:15  
---------------------------------------------------------------------- 
please do the same with dbmail-imapd:

#! /bin/sh  /usr/share/dpatch/dpatch-run
## 05_imap_log_failed_login_attempts.dpatch by  Michael Mende
<[EMAIL PROTECTED]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: Get more information about failed login attempts

@DPATCH@
diff -urNad dbmail-2.2.3/dbmail-imapsession.c
dbmail-2.2.3/dbmail-imapsession.c.orig
--- dbmail-2.2.3/dbmail-imapsession.c   2007-02-08 13:52:22.000000000 +0100
+++ dbmail-2.2.3/dbmail-imapsession.c.orig      2007-03-23 12:15:32.000000000
+0100
@@ -1393,7 +1393,7 @@
                sleep(2);       /* security */
 
                /* validation failed: invalid user/pass combination */
-               TRACE(TRACE_MESSAGE, "user (name %s) login rejected", username);
+               TRACE(TRACE_MESSAGE, "user (name %s) coming from [%s] login 
rejected",
username, self->ci->ip_src);
                dbmail_imap_session_printf(self, "%s NO login rejected\r\n",
self->tag);
 
                return 1; 

Issue History 
Date Modified   Username       Field                    Change               
====================================================================== 
19-Mar-07 14:16 menole         New Issue                                    
19-Mar-07 14:16 menole         File Added: 05_pop3.dpatch                    
23-Mar-07 13:54 paul           Note Added: 0001954                          
23-Mar-07 13:54 paul           Assigned To               => paul            
23-Mar-07 13:54 paul           Status                   new => resolved     
23-Mar-07 13:54 paul           Resolution               open => fixed       
23-Mar-07 13:54 paul           Fixed in Version          => 2.2.5           
24-Mar-07 20:15 menole         Status                   resolved => feedback
24-Mar-07 20:15 menole         Resolution               fixed => reopened   
24-Mar-07 20:15 menole         Note Added: 0001957                          
======================================================================

_______________________________________________
Dbmail-dev mailing list
[email protected]
http://twister.fastxs.net/mailman/listinfo/dbmail-dev

Reply via email to