Some additional comments:

- some kind of migration of current content, *or* backward compatibility
support is a must. The header caching tables have been present since
2.2.0, so a lot of users will have a lot of content. But I'm sure you've
already considered that.

One route would be to simply drop *all* the current caching tables,
recreate them, and fill them again using 'dbmail-util -yb'.
Crude but effective, though with added downtime. Perhaps something more
graceful should be considered.

- I'm not too happy with the table/field naming convention used by
Michael. So to keep things in line with the current convention I'd prefer:

dbmail_headervalue.value_id -> dbmail_headervalue.id
dbmail_headervalue.value -> dbmail_headervalue.headervalue
dbmail_headername.name_id -> dbmail_headername.id
dbmail_headername.name -> dbmail_headername.headername
dbmail_headernamevalue -> dbmail_header
dbmail_headernamevalue.name_id -> dbmail_header.headername_id
dbmail_headernamevalue.value_id -> dbmail_header.headervalue_id

- the index on dbmail_headervalue.headervalue must have a specified
width, or else the index will become a problem in itself since that
field is a blob.



Paul J Stevens wrote:
> Niki,
> 
> Very cool.
> 
> I haven't tested it yet, but I like the look of it so far.
> 
> One small piece of git-advice: git-rebase is your friend. Rather than
> pull-and-merge with my tree, try:
> 
> git rebase paul/master
> 
> assuming the 'remote' for my tree is called 'paul'.
> 
> That will create a much cleaner history of your changes.
> 
> Keep me posted, plz. I'd love to get this into 2.3.6 which I hope to be
> able to release over the next two weeks or so.
> 
> 
> 
> 
> Niki Guldbrand wrote:
>> Hi Folks.
>>
>> On 19 Jan 2009 michael Monnerie talked about adding single instance
>> header storage to dbmail.
>>
>> I now have a branch at git://git.guldbrand.net/niki/dbmail called
>> single_instance_header which implements this.
>>
>> Although I don't think it's finished yet, I would like to hear what
>> other people think about this.
>>
>> I have tried it in a test env, and there I have no issue using this code
>> I can store mails in the db via lmtp, and get the headers in my imap
>> client without issues.
>>
>>
>> Best Regards
>>
>> Niki Guldbrand
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Dbmail-dev mailing list
>> Dbmail-dev@dbmail.org
>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev
> 
> 


-- 
  ________________________________________________________________
  Paul Stevens                                      paul at nfg.nl
  NET FACILITIES GROUP                     GPG/PGP: 1024D/11F8CD31
  The Netherlands________________________________http://www.nfg.nl
_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://twister.fastxs.net/mailman/listinfo/dbmail-dev

Reply via email to