I'm looking at the code. Need to start somewhere. I have zero experience using key-stores in real-life, so I'll just let you do your thing.
Please read: http://developer.gnome.org/glib/2.32/glib-String-Utility-Functions.html because if you learn to use for example g_strdup_printf, that will clean up your code a lot. I'm seeing a lot of 1-liner functions. Those should either be inlined, or replace them with DEFINE's. You should study up on interfaces. It's a concept from object-oriented programming that I've used extensively in dbmail. For example check out dm_capa.[ch]. When I started using libzdb I noticed libzdb used this pattern and it rocks! It makes C code much more readable. At this moment I can't even determine your entry points. I see you're linking dm_memcache.o, but where is it actually being used?? What's with the first line in dm_memcache.h? Generated? By what? And why? Most functions in dm_memcache.c appear to be used inside that same module only. If so, they should not be exported in dm_memcache.h, but be marked 'static'. Please don't use memcache_ as a prefix for your functions. That prefix is used by libmemcache. You really don't want to get into a pissing contest with your upstream libs when a name collision occurs. Maybe a KVStore_ prefix would be better. If you setup your interfaces correctly you might even swap in alternative implementations based of for example Cassandra, Redis or some other key-value store at some point. And please read my pointers about GIT usage I sent separately. keep it up! -- ________________________________________________________________ Paul J Stevens pjstevns @ gmail, twitter, skype, linkedin * Premium Hosting Services and Web Application Consultancy * www.nfg.nl/i...@nfg.nl/+31.85.877.99.97 ________________________________________________________________ _______________________________________________ Dbmail-dev mailing list Dbmail-dev@dbmail.org http://mailman.fastxs.nl/cgi-bin/mailman/listinfo/dbmail-dev
